Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update withdrawal request contract address #8010

Closed

Conversation

macfarla
Copy link
Contributor

@macfarla macfarla commented Dec 9, 2024

PR description

Per EIP change https://github.com/ethereum/EIPs/pull/9119/files

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@macfarla macfarla added the Prague label Dec 9, 2024
@macfarla
Copy link
Contributor Author

ok some code needs updating in prague-withdrawal test

this 0x0000000000000000000000000000000000001000 is a proxy

0000    60  PUSH1 0x38
0002    60  PUSH1 0x00
0004    60  PUSH1 0x00
0006    37  CALLDATACOPY
0007    60  PUSH1 0x00
0009    60  PUSH1 0x00
000B    60  PUSH1 0x38
000D    60  PUSH1 0x00
000F    60  PUSH1 0x01
0011    73  PUSH20 0x09fc772d0857550724b07b850a4323f39112aaaa <<< this is the OLD withdrawal request address
0026    62  PUSH3 0x0f4240
002A    F1  CALL
002B    50  POP

@macfarla macfarla marked this pull request as draft December 10, 2024 07:06
@macfarla
Copy link
Contributor Author

replaced by #8016

@macfarla macfarla closed this Dec 11, 2024
@macfarla macfarla deleted the withdrawal-contract-address branch December 19, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants