-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/preimage store #7800
Draft
garyschulte
wants to merge
4
commits into
hyperledger:main
Choose a base branch
from
garyschulte:feature/preimage-store
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Feature/preimage store #7800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garyschulte
force-pushed
the
feature/preimage-store
branch
14 times, most recently
from
October 25, 2024 18:10
6f04716
to
84cf9c7
Compare
garyschulte
force-pushed
the
feature/preimage-store
branch
4 times, most recently
from
November 12, 2024 09:47
c765ebb
to
ccbbc42
Compare
garyschulte
force-pushed
the
feature/preimage-store
branch
from
November 19, 2024 17:28
476fdcf
to
562161b
Compare
garyschulte
commented
Dec 4, 2024
@@ -157,6 +157,11 @@ public boolean isClosed() { | |||
return closed.get(); | |||
} | |||
|
|||
@Override | |||
public boolean isPersistent() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think all of the isPersistent() methods are no longer necessary for this implementation. it is useful information to have, but it doesn't serve a purpose currently. probably should remove
garyschulte
force-pushed
the
feature/preimage-store
branch
3 times, most recently
from
December 18, 2024 00:05
1161f09
to
22a92af
Compare
Signed-off-by: garyschulte <[email protected]>
…plicit coverage Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
garyschulte
force-pushed
the
feature/preimage-store
branch
from
January 6, 2025 23:52
22a92af
to
1485e99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Draft status PR for preimage store.
Highlights include:
📝 Draft status,
✅ reference tests passing
still outstanding TODOs:
Fixed Issue(s)
fixes #7796
Thanks for sending a pull request! Have you done the following?
doc-change-required
label to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build
./gradlew acceptanceTest
./gradlew integrationTest
./gradlew ethereum:referenceTests:referenceTests