remove unneeded isPersistent

Signed-off-by: garyschulte <[email protected]>

plugin-api/build.gradle

@@ -71,7 +71,7 @@ Calculated : ${currentHash}
 tasks.register('checkAPIChanges', FileStateChecker) {
   description = "Checks that the API for the Plugin-API project does not change without deliberate thought"
   files = sourceSets.main.allJava.files
-  knownHash = '383yMOZRiNz6gXhjXhKXtNxZhVGzNXtnEcFUPDSNrY0='
+  knownHash = 'rV5/+XT2itQKN6+IG8CHX4a1DKH83FuyAo9N96Q73jc='
 }
 check.dependsOn('checkAPIChanges')
 

plugin-api/src/main/java/org/hyperledger/besu/plugin/services/storage/KeyValueStorage.java

@@ -143,11 +143,4 @@ public interface KeyValueStorage extends Closeable {
    * @return boolean indicating whether the storage is closed.
    */
   boolean isClosed();
-
-  /**
-   * Is this storage persistent or ephemeral.
-   *
-   * @return whether this storage type is persistent or not.
-   */
-  boolean isPersistent();
 }

plugin-api/src/main/java/org/hyperledger/besu/plugin/services/storage/SegmentedKeyValueStorage.java

@@ -195,11 +195,4 @@ public Optional<Bytes> wrapBytes() {
       return value.map(Bytes::wrap);
     }
   }
-
-  /**
-   * Whether this storage is persistent or ephemeral.
-   *
-   * @return if storage is persistent.
-   */
-  boolean isPersistent();
 }

plugins/rocksdb/src/main/java/org/hyperledger/besu/plugin/services/storage/rocksdb/segmented/RocksDBColumnarKeyValueSnapshot.java

@@ -157,11 +157,6 @@ public boolean isClosed() {
     return closed.get();
   }
 
-  @Override
-  public boolean isPersistent() {
-    return false;
-  }
-
   @Override
   public void clear(final SegmentIdentifier segment) {
     throw new UnsupportedOperationException(

plugins/rocksdb/src/main/java/org/hyperledger/besu/plugin/services/storage/rocksdb/segmented/RocksDBColumnarKeyValueStorage.java

@@ -482,9 +482,4 @@ public String forDisplay() {
       return String.format("'%s'(%s)", name, Bytes.of(id).toHexString());
     }
   }
-
-  @Override
-  public boolean isPersistent() {
-    return true;
-  }
 }

services/kvstore/src/main/java/org/hyperledger/besu/services/kvstore/InMemoryKeyValueStorage.java

@@ -101,9 +101,4 @@ public InMemoryKeyValueStorage(final SegmentIdentifier segmentIdentifier) {
   public void dump(final PrintStream ps) {
     ((SegmentedInMemoryKeyValueStorage) storage).dump(ps);
   }
-
-  @Override
-  public boolean isPersistent() {
-    return false;
-  }
 }

services/kvstore/src/main/java/org/hyperledger/besu/services/kvstore/LimitedInMemoryKeyValueStorage.java

@@ -162,11 +162,6 @@ public boolean isClosed() {
     return false;
   }
 
-  @Override
-  public boolean isPersistent() {
-    return false;
-  }
-
   private class MemoryTransaction implements KeyValueStorageTransaction {
 
     private Map<Bytes, byte[]> updatedValues = new HashMap<>();

services/kvstore/src/main/java/org/hyperledger/besu/services/kvstore/SegmentedInMemoryKeyValueStorage.java

@@ -310,11 +310,6 @@ public boolean isClosed() {
     return false;
   }
 
-  @Override
-  public boolean isPersistent() {
-    return false;
-  }
-
   @Override
   public SegmentedInMemoryKeyValueStorage takeSnapshot() {
     // need to clone the submaps also:

services/kvstore/src/main/java/org/hyperledger/besu/services/kvstore/SegmentedKeyValueStorageAdapter.java

@@ -130,11 +130,6 @@ public boolean isClosed() {
     return storage.isClosed();
   }
 
-  @Override
-  public boolean isPersistent() {
-    return storage.isPersistent();
-  }
-
   private void throwIfClosed() {
     if (storage.isClosed()) {
       LOG.error("Attempting to use a closed Storage instance.");