Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile - reuse NO_PROXY_CACHE env #7203

Merged
merged 5 commits into from
Jun 13, 2024
Merged

Update Dockerfile - reuse NO_PROXY_CACHE env #7203

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c28f290
Update Dockerfile
tbenr Jun 11, 2024
1f99f6d
Merge branch 'main' into patch-1
usmansaleem Jun 11, 2024
d956064
Update Dockerfile
tbenr Jun 12, 2024
915e7a6
Merge branch 'main' into patch-1
tbenr Jun 12, 2024
421fd97
Merge branch 'main' into patch-1
macfarla Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ ENV NO_PROXY_CACHE="-o Acquire::BrokenProxy=true -o Acquire::http::No-Cache=true
# Update and install dependencies without using any cache
RUN apt-get update $NO_PROXY_CACHE && \
# $NO_PROXY_CACHE must not be used here or otherwise will trigger a hadolint error
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: we can remove the above comment as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there was an actual bug in my changes. Fixed and removed a redundant rm -rf

apt-get -o Acquire::BrokenProxy=true -o Acquire::http::No-Cache=true -o Acquire::http::Pipeline-Depth=0 \
apt-get $NO_PROXY_CACHE && \
--no-install-recommends -q --assume-yes install openjdk-21-jre-headless=21* libjemalloc-dev=5.* adduser=3* && \
# Clean apt cache
apt-get clean && \
Expand Down
Loading