Update Dockerfile - reuse NO_PROXY_CACHE env #7203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reuse NO_PROXY_CACHE env Signed-off-by: Enrico Del Fante <[email protected]>
usmansaleem
reviewed
Jun 11, 2024
docker/Dockerfile
Outdated
| @@ -6,7 +6,7 @@ ENV NO_PROXY_CACHE="-o Acquire::BrokenProxy=true -o Acquire::http::No-Cache=true | |||
| # Update and install dependencies without using any cache | |||
| RUN apt-get update $NO_PROXY_CACHE && \ | |||
| # $NO_PROXY_CACHE must not be used here or otherwise will trigger a hadolint error | |||
There was a problem hiding this comment.
nit: we can remove the above comment as well.
There was a problem hiding this comment.
there was an actual bug in my changes. Fixed and removed a redundant rm -rf
Signed-off-by: Enrico Del Fante <[email protected]>
macfarla
added a commit
to macfarla/besu
that referenced
this pull request
Jun 13, 2024
This reverts commit dfe256e. Signed-off-by: Sally MacFarlane <[email protected]>
8 tasks
macfarla
added a commit
that referenced
this pull request
Jun 13, 2024
This reverts commit dfe256e. Signed-off-by: Sally MacFarlane <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just noticed this.