-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: unable to install games on linux #304
Conversation
Finally got able to install a linux disto on my PC, will test your PR today |
Gonna post here the same commend I posted on #299 just to make it more visible: May I suggest something?
The Windows conditional remains the same as it is in your PR. These checks should happen after that. |
I'll have a free time later today and I'm planning to take a look into it. Feel free to apply any changes though. |
I have implemented the changes you suggested with one single consideration: the first step of the installation process is now to check if the game path actually leads to a file (not a directory). If it does, we proceed to execute it, assuming it is the game installer. This is important for cases like 18 Wheels of Steel: Across America, where the game comes as a single file, and it also makes all other handling more reasonable. Additionally, I created a function to execute files based on the operating system. This way, we avoid duplicating the Wine logic. I tested these changes using different games that come in various formats, including:
Everything seems to be working well. It's important to note that the Lutris logic has become less useful as we now employ a Wine-first approach. However, this doesn't seem like a problem since the current Lutris implementation relies on having a Let me know if you think something should be different or seems wrong. |
The only thing I'm worried is if there are any game that can have more than one . |
It's a fair concern. We could improve what we have by looking for something similar to "setup.exe", "{gamename}.exe", you name it. There is no silver bullet though. I do think this PR improve some cases, I had one with NFS (I think) where it comes with a "nfs-something.exe" and it was well handled, so... |
Ideally we would know exactly what to run, but as it's not possible right now we will have to do some assumptions. |
There is a issue when installing games on Linux. I described it in #299.
Fixes #299