fixing the game installer in linux where it opens archive manager. #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue where game installers were not being properly handled on Linux systems. The existing code was appending "setup.exe" to the game path, which resulted in an invalid path and caused the installer to be opened with the default application (e.g., Archive Manager) instead of using Lutris or Wine as intended.
The fix involves removing the unnecessary code that checks for existence of "setup.exe", allowing the existing logic to handle opening the installer with Lutris or Wine correctly.
To reproduce the issue:
Before this change, the installer would fail to open correctly on Linux systems. After this change, the installer should open with Lutris or Wine as expected.
No other changes or regressions are introduced with this PR.