Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove upper transformers version limit #2048

Merged
merged 1 commit into from
Oct 10, 2024
Merged

remove upper transformers version limit #2048

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
REQUIRED_PKGS = [
"coloredlogs",
"sympy",
"transformers[sentencepiece]>=4.29,<4.46.0",
"transformers[sentencepiece]>=4.29",
"torch>=1.11",
"packaging",
"numpy",
Expand Down Expand Up @@ -54,6 +54,7 @@
"datasets>=1.2.1",
"evaluate",
"protobuf>=3.20.1",
"transformers<4.46.0",
],
"onnxruntime-gpu": [
"onnx",
Expand All @@ -62,9 +63,10 @@
"evaluate",
"protobuf>=3.20.1",
"accelerate", # ORTTrainer requires it.
"transformers<4.46.0",
],
"exporters": ["onnx", "onnxruntime", "timm"],
"exporters-gpu": ["onnx", "onnxruntime-gpu", "timm"],
"exporters": ["onnx", "onnxruntime", "timm", "transformers<4.46.0"],
"exporters-gpu": ["onnx", "onnxruntime-gpu", "timm", "transformers<4.46.0"],
"exporters-tf": [
"tensorflow>=2.4,<=2.12.1",
"tf2onnx",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can also lift the explicit restrictions here also, since optimum-neuron will enforce a pinned version anyway (cc @JingyaHuang ):

    "neuron": ["optimum-neuron[neuron]>=0.0.20", "transformers>=4.36.2,<4.42.0"],
    "neuronx": ["optimum-neuron[neuronx]>=0.0.20", "transformers>=4.36.2,<4.42.0"],

Copy link
Collaborator Author

@echarlaix echarlaix Oct 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me know if you'd like me to include this change in today's release @JingyaHuang

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dacorvo you mean something like:

    "neuron": ["optimum-neuron[neuron]>=0.0.20", "transformers>=4.36.2,<=4.43.2"],
    "neuronx": ["optimum-neuron[neuronx]>=0.0.20", "transformers>=4.36.2,<=4.43.2"],

? Or you would that we remove transformers from the extra? if so wouldn't we install once again a super old optimum-neuron if we do

pip install optimum[neuronx]

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging this PR as not directly related to this discussion, let me know if you want me to include any modification related to neuron in todays release!

Expand Down
Loading