remove upper transformers version limit #2048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echarlaix
requested review from
JingyaHuang,
regisss,
IlyasMoutawwakil and
michaelbenayoun
JingyaHuang
approved these changes
Oct 10, 2024
dacorvo
reviewed
Oct 10, 2024
| "exporters": ["onnx", "onnxruntime", "timm"], | ||
| "exporters-gpu": ["onnx", "onnxruntime-gpu", "timm"], | ||
| "exporters": ["onnx", "onnxruntime", "timm", "transformers<4.46.0"], | ||
| "exporters-gpu": ["onnx", "onnxruntime-gpu", "timm", "transformers<4.46.0"], | ||
| "exporters-tf": [ | ||
| "tensorflow>=2.4,<=2.12.1", | ||
| "tf2onnx", |
There was a problem hiding this comment.
Maybe we can also lift the explicit restrictions here also, since optimum-neuron will enforce a pinned version anyway (cc @JingyaHuang ):
"neuron": ["optimum-neuron[neuron]>=0.0.20", "transformers>=4.36.2,<4.42.0"],
"neuronx": ["optimum-neuron[neuronx]>=0.0.20", "transformers>=4.36.2,<4.42.0"],There was a problem hiding this comment.
let me know if you'd like me to include this change in today's release @JingyaHuang
There was a problem hiding this comment.
@dacorvo you mean something like:
"neuron": ["optimum-neuron[neuron]>=0.0.20", "transformers>=4.36.2,<=4.43.2"],
"neuronx": ["optimum-neuron[neuronx]>=0.0.20", "transformers>=4.36.2,<=4.43.2"],
? Or you would that we remove transformers from the extra? if so wouldn't we install once again a super old optimum-neuron if we do
pip install optimum[neuronx]
There was a problem hiding this comment.
merging this PR as not directly related to this discussion, let me know if you want me to include any modification related to neuron in todays release!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To not block a release from optimum-intel, optimum-neuron, optimum-habana and others to support the latest transformers release (removing the need to dsync it with an optimum release)