Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run linter #975

Merged
merged 3 commits into from
Sep 28, 2023
Merged

Run linter #975

merged 3 commits into from
Sep 28, 2023

Conversation

mishig25
Copy link
Collaborator

@mishig25 mishig25 commented Sep 27, 2023

Should be merged into branch why #974

This PR:

  1. Formats the files so that CI passes
  2. Add eslint alphabetize rule 68c6c5a so that you don't need to manually sort 12a3381. However, we don't have this alphabetize in moon. And we are supposed to align with moon as written in Align prettier config #924 @krampstudio wdyt?

@mishig25 mishig25 marked this pull request as ready for review September 27, 2023 21:11
@mishig25 mishig25 mentioned this pull request Sep 27, 2023
@krampstudio
Copy link
Contributor

2. Add eslint `alphabetize` rule [68c6c5a](https://github.com/huggingface/hub-docs/commit/68c6c5ae044c6804c118013aebca19a7dc808fb4) so that you don't need to manually sort [12a3381](https://github.com/huggingface/hub-docs/commit/12a3381b9a8b849cd8d8d93c7fd85e348d6524ec). However, we don't have this `alphabetize` in moon. And we are supposed to align with moon as written in [Align prettier config #924](https://github.com/huggingface/hub-docs/pull/924) @krampstudio wdyt?

eslint config can be specialized, so you can use the base rules from moon and add dedicated rules/plugins for hub_docs if it makes sense

Base automatically changed from why to main September 28, 2023 09:46
@julien-c
Copy link
Member

don't think we really need alphabetize though

@mishig25 mishig25 changed the title npm run format:all Run linter Sep 28, 2023
@julien-c julien-c merged commit 257b0f2 into main Sep 28, 2023
2 checks passed
@julien-c julien-c deleted the whywhy branch September 28, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants