Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hmm 🤔 #974

Merged
merged 2 commits into from
Sep 28, 2023
Merged

hmm 🤔 #974

merged 2 commits into from
Sep 28, 2023

Conversation

julien-c
Copy link
Member

Screenshot 2023-09-27 at 20 06 07

@julien-c julien-c requested a review from mishig25 September 27, 2023 18:07
osanseviero
osanseviero approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@osanseviero osanseviero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although it would be nice to update the number of stars in those repos as well! ;)

@mishig25 mishig25 mentioned this pull request Sep 27, 2023
Merged
@mishig25
Copy link
Collaborator

Here is a PR #975

@julien-c
Copy link
Member Author

LGTM, although it would be nice to update the number of stars in those repos as well! ;)

I didn't understand this comment. Which repos?

@julien-c
Copy link
Member Author

haha ok you mean in the widget sample input?

@julien-c
Copy link
Member Author

this PR was more about the extraneous weird s btw. Merging to fix

@julien-c julien-c merged commit f2f3369 into main Sep 28, 2023
@julien-c julien-c deleted the why branch September 28, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osanseviero osanseviero osanseviero approved these changes

@mishig25 mishig25 Awaiting requested review from mishig25

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@julien-c @mishig25 @osanseviero