Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ControlNetXS into Community Folder #6316

Merged
merged 13 commits into from
Dec 27, 2023
Merged

Move ControlNetXS into Community Folder #6316

merged 13 commits into from
Dec 27, 2023

Conversation

DN6
Copy link
Collaborator

@DN6 DN6 commented Dec 25, 2023

What does this PR do?

I don't think we can currently support the implementation of ControlNetXS (#5827) as is in the release version of diffusers.

This PR:

  1. Moves it into the community folder so that an implementation is still available to the community.
  2. Adds an example inference script that users can use to test the model.

We can revisit this design and adding it into source based on community interest.

Fixes # (issue)

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@DN6 DN6 requested a review from sayakpaul December 25, 2023 05:58
Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to delete these tests after ControlNetXS has been moved to community.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@DN6 DN6 changed the title Skip ControlNetXS tests in CI Move ControlNetXS into Community Folder Dec 25, 2023
Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me. It would make sense to also remove the documentation and add a note about ControlNetXS from the community README. Let's also have Umer as a co-author since they contributed the pipeline initially. WDYT?

@patrickvonplaten
Copy link
Contributor

Can we instead move all the code to the research folder? We should only add code to examples/community that works with from_pretrained(custom_pipeline="...")

@sayakpaul
Copy link
Member

@patrickvonplaten done.

@sayakpaul sayakpaul merged commit c1e8bdf into main Dec 27, 2023
16 checks passed
@sayakpaul sayakpaul deleted the controlnetxs-tests branch December 27, 2023 02:45
donhardman pushed a commit to donhardman/diffusers that referenced this pull request Dec 29, 2023
* update

* update

* update

* update

* update

* make style

* remove docs

* update

* move to research folder.

* fix-copies

* remove _toctree entry.

---------

Co-authored-by: Sayak Paul <[email protected]>
antoine-scenario pushed a commit to antoine-scenario/diffusers that referenced this pull request Jan 2, 2024
* update

* update

* update

* update

* update

* make style

* remove docs

* update

* move to research folder.

* fix-copies

* remove _toctree entry.

---------

Co-authored-by: Sayak Paul <[email protected]>
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
* update

* update

* update

* update

* update

* make style

* remove docs

* update

* move to research folder.

* fix-copies

* remove _toctree entry.

---------

Co-authored-by: Sayak Paul <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants