Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SDXL Inpainting from single file with Refiner Model #6147

Merged
merged 3 commits into from
Dec 18, 2023

Conversation

DN6
Copy link
Collaborator

@DN6 DN6 commented Dec 12, 2023

What does this PR do?

Some refinements to from_single_file for the SDXL Inpainting model that allows it to work with the SDXL Refiner checkpoint.

Also cleans up a lot of redundant checks and object creation in the download_from_original_stable_diffusion_ckpt function.

Fixes # (issue)
#6001

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@DN6 DN6 requested review from sayakpaul and yiyixuxu December 12, 2023 14:07
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@DN6
Copy link
Collaborator Author

DN6 commented Dec 12, 2023

Hi @StandardAI. In this particular case, I was removing a chunk of redundant code in order to keep the covnvert_from_ckpt function from growing more. If it were just a few small changes I would have pushed to your PR.

Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Can we add some tests here or modify the single_file tests to include assertions to ensure that the correct pipeline classes are returned from these utilities?

Copy link
Collaborator

@yiyixuxu yiyixuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@patrickvonplaten
Copy link
Contributor

Let's merge this for now and then start the bigger refactor of from_single_file .

It's actually a bit tricky to add tests here since it's really difficult to create dummy models.

@patrickvonplaten patrickvonplaten merged commit fcbed3f into main Dec 18, 2023
16 checks passed
@patrickvonplaten patrickvonplaten deleted the sdxl-inpainting-singlefile branch December 18, 2023 10:45
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
donhardman pushed a commit to donhardman/diffusers that referenced this pull request Dec 29, 2023
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants