Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let soundfile directly read local audio files #7278

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Let soundfile directly read local audio files #7278

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3cbb06
Update audio.py
fawazahmed0 Nov 4, 2024
efdc211
make sure path is not none
fawazahmed0 Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/datasets/features/audio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,8 +166,9 @@ def decode_example(
"Decoding 'mp3' files requires system library 'libsndfile'>=1.1.0, "
'You can try to update `soundfile` python library: `pip install "soundfile>=0.12.1"`. '
)

if file is None:
if path is not None and os.path.exists(path):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

os.path.exists() returns true if path is a directory, mind.

array, sampling_rate = sf.read(path)
elif file is None:
token_per_repo_id = token_per_repo_id or {}
source_url = path.split("::")[-1]
pattern = (
Expand Down