Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let soundfile directly read local audio files #7278

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Let soundfile directly read local audio files #7278

wants to merge 2 commits into from

Conversation

fawazahmed0
Copy link

@fawazahmed0 fawazahmed0 commented Nov 4, 2024 •
edited
Loading

akx
akx reviewed Nov 18, 2024
View reviewed changes
src/datasets/features/audio.py
@@ -166,8 +166,9 @@ def decode_example(
"Decoding 'mp3' files requires system library 'libsndfile'>=1.1.0, "
'You can try to update `soundfile` python library: `pip install "soundfile>=0.12.1"`. '
)

if file is None:
if path is not None and os.path.exists(path):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

os.path.exists() returns true if path is a directory, mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akx akx akx left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Accessing audio dataset value throws Format not recognised error
2 participants
@fawazahmed0 @akx