Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🎸 add POST /admin/recreate-dataset?dataset=.&priority= #1884

Merged
merged 10 commits into from
Sep 29, 2023

Conversation

severo
Copy link
Collaborator

@severo severo commented Sep 28, 2023

see
#1823 (comment)

Missing:

  • tests (it's destructive, so: better to ensure we don't affect other datasets for example)
  • add a tab in the admin UI

@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2023

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (3c6c79b) 87.65% compared to head (aebc230) 90.63%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1884      +/-   ##
==========================================
+ Coverage   87.65%   90.63%   +2.97%     
==========================================
  Files          22      233     +211     
  Lines         875    14424   +13549     
==========================================
+ Hits          767    13073   +12306     
- Misses        108     1351    +1243     
Flag Coverage Δ
jobs_cache_maintenance 96.66% <ø> (?)
jobs_mongodb_migration 86.32% <ø> (?)
libs_libcommon 91.72% <100.00%> (?)
services_admin 85.69% <45.23%> (-1.96%) ⬇️
services_api 86.79% <ø> (?)
services_rows 84.16% <ø> (?)
services_search 78.55% <ø> (?)
services_sse-api 94.16% <ø> (?)
services_worker 92.56% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
libs/libcommon/src/libcommon/queue.py 89.18% <100.00%> (ø)
libs/libcommon/tests/test_queue.py 100.00% <100.00%> (ø)
services/admin/src/admin/app.py 89.47% <100.00%> (+0.18%) ⬆️
services/admin/src/admin/routes/obsolete_cache.py 94.64% <100.00%> (ø)
services/admin/tests/routes/test_obsolete_cache.py 100.00% <ø> (ø)
...ervices/admin/src/admin/routes/recreate_dataset.py 42.50% <42.50%> (ø)

... and 208 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@severo severo merged commit 1e2b670 into main Sep 29, 2023
@severo severo deleted the conditionally-delete-downstream-steps branch September 29, 2023 13:42
@severo
Copy link
Collaborator Author

severo commented Sep 29, 2023

thanks for the reviews @AndreaFrancis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants