Sync states for npu fsdp #2093
Closed
Sync states for npu fsdp #2093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
statelesshz
approved these changes
Oct 27, 2023
|
cc @pacman100, @muellerzr and @BenjaminBossan, please take a look as this PR, thanks :) |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
|
@jq460494839 The import is not sorted correctly, could you please fix that? |
fixed. |
statelesshz
approved these changes
Oct 28, 2023
|
Hi @muellerzr would mind having a look at this PR? It links to #1777 |
muellerzr
approved these changes
Oct 31, 2023
src/accelerate/utils/dataclasses.py
Outdated
| elif is_xpu_available(): | ||
| device = torch.xpu.current_device() | ||
| else: | ||
| raise RuntimeError("There are currently no available device found in ['XPU', 'CUDA', 'NPU']!") |
There was a problem hiding this comment.
Suggested change
| raise RuntimeError("There are currently no available device found in ['XPU', 'CUDA', 'NPU']!") | |
| raise RuntimeError("There are currently no available devices found, must be one of 'XPU', 'CUDA', or 'NPU'.") |
|
Can you run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds sync state for fsdp loading on rank 0 -> broadcasted to other npu ranks.
cc @pacman100 @statelesshz
Fixes #2085 Use FastChat with NPU fine-tune LLM get an AssertionError