Sync states for npu fsdp #2113
Merged
Sync states for npu fsdp #2113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, the previous PR was mistakenly closed by me. Could you please help me review and merge it again |
|
#2093 for reference. |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
thanks |
statelesshz
approved these changes
Nov 3, 2023
|
@pacman100 Please take a look at this PR, thx. |
pacman100
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds sync state for fsdp loading on rank 0 -> broadcasted to other npu ranks.
cc @pacman100 @statelesshz @muellerzr
Fixes #2085