Patch for MLC fix and exclusive L1 support #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The mlc_fill_line was not handling insertion correctly. WB of victim was handled after new line got inserted. The same issue didn't appear in l1_fill_line * Add option to support private mlc * Turn on MLC by default
* Add an option to model non-inclusive LLC (l1). When turned on, demand req will be steered into MLC directly, and L1 works as victim cache to MLC. * Bug fix in mlc_fill * Fix the lost of dirty bit when promoting L1 line to MLC. Use the dirty_l0 from req to carry the dirtyness info * Revised the mlc_hit logic. Req hit in mlc should be sent to cores' fill queues instead of directly calling done_func at MLC * Fix the code format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix previous issue when enabling MLC. Also add support for exclusive L1 and private MLC.
Improve the comments in memory.c
I did couple tests (both single-core and multi-core with multi-programmed workloads) with simple u-benchmarks. The results looks correct. But in case any performance anomaly arise in the future after enabling MLC, I am happy to take a look.
I already squashed all commits into three kinda independent ones, thus suggest not to squash further when merging to the mainline.