Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-33062 Document the process to restore Dali from backup #19392

Merged

Conversation

JamesDeFabia
Copy link
Contributor

@JamesDeFabia JamesDeFabia commented Jan 9, 2025

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

Built successfully and PDF looks ok:
https://github.com/JamesDeFabia/github-action-dev-build/actions/runs/12691817597

Copy link

github-actions bot commented Jan 9, 2025

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-33062

Jirabot Action Result:
Workflow Transition To: Merge Pending
Updated PR

@JamesDeFabia JamesDeFabia force-pushed the HPCC-33062DaliRestore branch 2 times, most recently from 43fa8a9 to 04d976f Compare January 10, 2025 15:35
Copy link
Member

@g-pan g-pan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Copy link
Member

@jakesmith jakesmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JamesDeFabia - please see comment, and there seem to have been quite a lot of rogue spaces before "/>" introduced in this PR.

@JamesDeFabia
Copy link
Contributor Author

@jakesmith I made the two changes you requested and used the new version of the editor to eliminate the spurious changes. Please have another look

Copy link
Member

@jakesmith jakesmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JamesDeFabia - looks good. Please squash.

@JamesDeFabia JamesDeFabia force-pushed the HPCC-33062DaliRestore branch from fb819e5 to f87e8d5 Compare January 17, 2025 14:29
@JamesDeFabia
Copy link
Contributor Author

Squashed.
@ghalliday This should be good to merge now

@ghalliday ghalliday merged commit 5f07c3a into hpcc-systems:candidate-9.8.x Jan 20, 2025
49 checks passed
Copy link

Jirabot Action Result:
Added fix version: 9.8.50
Workflow Transition: 'Resolve issue'

@JamesDeFabia JamesDeFabia deleted the HPCC-33062DaliRestore branch January 21, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants