Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-31643 Parquet Plugin does not support VARUNICODE #18558

Merged
merged 1 commit into from
May 2, 2024
Merged

HPCC-31643 Parquet Plugin does not support VARUNICODE #18558

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 3 additions & 14 deletions plugins/parquet/parquetembed.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -722,24 +722,13 @@ arrow::Status ParquetWriter::fieldToNode(const std::string &name, const RtlField
case type_real:
arrowFields.push_back(std::make_shared<arrow::Field>(name, arrow::float64()));
break;
case type_string:
arrowFields.push_back(std::make_shared<arrow::Field>(name, arrow::utf8()));
break;
case type_char:
arrowFields.push_back(std::make_shared<arrow::Field>(name, arrow::utf8()));
break;
case type_string:
case type_varstring:
arrowFields.push_back(std::make_shared<arrow::Field>(name, arrow::utf8()));
break;
case type_qstring:
arrowFields.push_back(std::make_shared<arrow::Field>(name, arrow::utf8()));
break;
case type_unicode:
arrowFields.push_back(std::make_shared<arrow::Field>(name, arrow::utf8()));
break;
case type_utf8:
arrowFields.push_back(std::make_shared<arrow::Field>(name, arrow::utf8()));
break;
case type_unicode:
case type_varunicode:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is more stylistic than anything else, but I would combine all of the case options that result in exactly the same result (arrow::utf8). At least for all these string-like data types.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

case type_decimal:
arrowFields.push_back(std::make_shared<arrow::Field>(name, arrow::utf8())); //TODO add decimal encoding
break;
Expand Down
Loading