Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-31643 Parquet Plugin does not support VARUNICODE #18558

Merged
merged 1 commit into from
May 2, 2024
Merged

HPCC-31643 Parquet Plugin does not support VARUNICODE #18558

merged 1 commit into from
May 2, 2024

Conversation

jackdelv
Copy link
Contributor

@jackdelv jackdelv commented Apr 18, 2024 •
edited
Loading

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@jackdelv jackdelv requested a review from dcamper April 18, 2024 20:11
@github-actions GitHub Actions
Copy link

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-31643

Jirabot Action Result:
Workflow Transition: Merge Pending
Updated PR

@jackdelv jackdelv changed the base branch from master to candidate-9.6.x April 18, 2024 20:11
dcamper
dcamper requested changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@dcamper dcamper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor stylistic change.

plugins/parquet/parquetembed.cpp
case type_utf8:
case type_unicode:
case type_varunicode:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is more stylistic than anything else, but I would combine all of the case options that result in exactly the same result (arrow::utf8). At least for all these string-like data types.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@jackdelv jackdelv requested a review from dcamper April 19, 2024 12:48
dcamper
dcamper approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@dcamper dcamper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

ghalliday
ghalliday approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@ghalliday ghalliday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jackdelv please squash

@jackdelv
Copy link
Contributor Author

@ghalliday Squashed.

@jackdelv jackdelv requested a review from ghalliday April 29, 2024 12:03
@ghalliday ghalliday closed this May 1, 2024
@ghalliday ghalliday reopened this May 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 1, 2024

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-31643

Jirabot Action Result:

@ghalliday ghalliday merged commit 2983fcd into hpcc-systems:candidate-9.6.x May 2, 2024
74 of 79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcamper dcamper dcamper approved these changes

@ghalliday ghalliday ghalliday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jackdelv @ghalliday @dcamper