Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-30194 Nodejs v16 deprecation in 8.12.x build-assets fix #18287

Merged
merged 1 commit into from
Feb 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-and-publish-debug.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
if: github.repository == 'hpcc-systems/HPCC-Platform'
steps:
- name: Checkout
uses: actions/checkout@v2
uses: actions/checkout@v4
- name: Build
uses: ./dockerfiles
with:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/build-and-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
if: github.repository == 'hpcc-systems/HPCC-Platform'
steps:
- name: Checkout
uses: actions/checkout@v2
uses: actions/checkout@v4
- name: Build
uses: ./dockerfiles
with:
Expand All @@ -42,7 +42,7 @@ jobs:
engine: ['ml', 'gnn', 'gnn-gpu']
steps:
- name: Checkout
uses: actions/checkout@v2
uses: actions/checkout@v4
- name: Build
uses: ./dockerfiles
with:
Expand Down
34 changes: 17 additions & 17 deletions .github/workflows/build-assets.yml
Original file line number Diff line number Diff line change
Expand Up @@ -68,14 +68,14 @@ jobs:
echo "${{ toJSON(steps.vars.outputs) }})"

- name: Release HPCC-Platform
uses: ncipollo/release-action@v1.12.0
uses: ncipollo/release-action@v1.14.0
with:
allowUpdates: true
generateReleaseNotes: false
prerelease: ${{ contains(github.ref, '-rc') }}

- name: Release LN
uses: ncipollo/release-action@v1.12.0
uses: ncipollo/release-action@v1.14.0
with:
allowUpdates: true
generateReleaseNotes: false
Expand Down Expand Up @@ -123,15 +123,15 @@ jobs:
sudo rm -rf /usr/local/lib/android

- name: Checkout HPCC-Platform
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
ref: ${{ needs.preamble.outputs.community_ref }}
submodules: recursive
path: ${{ needs.preamble.outputs.folder_platform }}

- name: Checkout LN
if: ${{ matrix.ln }}
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
repository: ${{ github.repository_owner }}/LN
token: ${{ secrets.LNB_TOKEN }}
Expand All @@ -157,16 +157,16 @@ jobs:

- name: Set up Docker Buildx
id: buildx
uses: docker/setup-buildx-action@v2
uses: docker/setup-buildx-action@v3

- name: Login to DockerHub
uses: docker/login-action@v2
uses: docker/login-action@v3
with:
username: ${{ secrets.DOCKER_USERNAME }}
password: ${{ secrets.DOCKER_PASSWORD }}

- name: Create Build Image
uses: docker/build-push-action@v4
uses: docker/build-push-action@v5
with:
builder: ${{ steps.buildx.outputs.name }}
file: ${{ needs.preamble.outputs.folder_platform }}/dockerfiles/vcpkg/${{ matrix.os }}.dockerfile
Expand Down Expand Up @@ -228,7 +228,7 @@ jobs:

- name: Upload Assets (community)
if: ${{ !matrix.ln }}
uses: ncipollo/release-action@v1.12.0
uses: ncipollo/release-action@v1.14.0
with:
allowUpdates: true
generateReleaseNotes: false
Expand All @@ -245,7 +245,7 @@ jobs:
echo "$k8s_pkg_file"

- name: Create Docker Image (community)
uses: docker/build-push-action@v4
uses: docker/build-push-action@v5
if: ${{ !matrix.ln && matrix.container && !matrix.documentation }}
with:
builder: ${{ steps.buildx.outputs.name }}
Expand All @@ -263,7 +263,7 @@ jobs:
# Internal Build ---
- name: Login to JFrog (internal)
if: ${{ matrix.ln && matrix.container && github.repository_owner == 'hpcc-systems' }}
uses: docker/login-action@v2
uses: docker/login-action@v3
with:
registry: ${{ secrets.JFROG_REGISTRY }}
username: ${{ secrets.JFROG_USERNAME }}
Expand Down Expand Up @@ -310,7 +310,7 @@ jobs:

- name: Upload Assets (internal)
if: ${{ matrix.ln }}
uses: ncipollo/release-action@v1.12.0
uses: ncipollo/release-action@v1.14.0
with:
allowUpdates: true
generateReleaseNotes: false
Expand Down Expand Up @@ -359,7 +359,7 @@ jobs:

- name: Upload error logs
if: ${{ failure() || cancelled() }}
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: ${{ matrix.os }}-${{ matrix.ln }}-${{ matrix.container }}-${{ matrix.documentation }}-logs
path: ${{ needs.preamble.outputs.folder_build }}/**/*.log
Expand Down Expand Up @@ -404,14 +404,14 @@ jobs:
${{ matrix.sudo }} rm -rf "$VCPKG_INSTALLATION_ROOT"

- name: Checkout HPCC-Platform
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
ref: ${{ needs.preamble.outputs.community_ref }}
submodules: recursive
path: ./HPCC-Platform

- name: Checkout LN
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
repository: ${{ github.repository_owner }}/LN
token: ${{ secrets.LNB_TOKEN }}
Expand Down Expand Up @@ -443,7 +443,7 @@ jobs:
cmake --build ./build ${{ matrix.cmake_build_options }} --target package

- name: Upload Assets
uses: ncipollo/release-action@v1.12.0
uses: ncipollo/release-action@v1.14.0
with:
allowUpdates: true
generateReleaseNotes: false
Expand All @@ -459,7 +459,7 @@ jobs:
cmake --build ./build ${{ matrix.cmake_build_options }} --target package

- name: Upload LN Assets
uses: ncipollo/release-action@v1.12.0
uses: ncipollo/release-action@v1.14.0
with:
allowUpdates: true
generateReleaseNotes: false
Expand All @@ -472,7 +472,7 @@ jobs:

- name: Upload error logs
if: ${{ failure() || cancelled() }}
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: ${{ matrix.os }}-logs
path: ./build/**/*.log
8 changes: 4 additions & 4 deletions .github/workflows/build-containers-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ jobs:
echo "platform_build = ${{ steps.vars.outputs.platform_build }}"

- name: Checkout PR
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Calculate vcpkg vars
id: vcpkg_vars
Expand All @@ -78,7 +78,7 @@ jobs:

- name: Set up Docker Buildx
id: buildx
uses: docker/setup-buildx-action@v1
uses: docker/setup-buildx-action@v3
with:
driver: docker

Expand Down Expand Up @@ -107,7 +107,7 @@ jobs:
# or they'll be a "latest" which will have been picked up by the check-images step.
- name: branch image
if: ${{ steps.check-images.outputs.prbase_missing == '1' }}
uses: docker/build-push-action@v2
uses: docker/build-push-action@v5
with:
context: .
file: ./dockerfiles/platform-build/Dockerfile
Expand All @@ -127,7 +127,7 @@ jobs:
BUILD_THREADS=${{ steps.vars.outputs.build_threads }}

- name: PR image
uses: docker/build-push-action@v2
uses: docker/build-push-action@v5
with:
context: .
file: ./dockerfiles/platform-build-incremental-container/Dockerfile
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/build-containers-target-branch.yml
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ jobs:
echo "build_base_label = ${{ steps.vars.outputs.build_base_label }}"

- name: Checkout
uses: actions/checkout@v2
uses: actions/checkout@v4

- name: Calculate vcpkg vars
id: vcpkg_vars
Expand All @@ -75,24 +75,24 @@ jobs:

- name: Set up Docker Buildx
id: buildx
uses: docker/setup-buildx-action@v1
uses: docker/setup-buildx-action@v3

# - name: Login to GitHub Container Registry
# uses: docker/login-action@v1
# uses: docker/login-action@v3
# with:
# registry: ghcr.io
# username: ${{ github.repository_owner }}
# password: ${{ secrets.GITHUB_TOKEN }}

- name: Login to DockerHub
uses: docker/login-action@v1
uses: docker/login-action@v3
with:
username: ${{ secrets.DOCKER_USERNAME }}
password: ${{ secrets.DOCKER_PASSWORD }}

# build branch image
- name: branch image
uses: docker/build-push-action@v2
uses: docker/build-push-action@v5
with:
context: .
file: ./dockerfiles/platform-build/Dockerfile
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/build-test-eclwatch.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,21 +25,21 @@ jobs:
build:
strategy:
matrix:
node: ["16", "14"]
node: ["20", "18", "16"]
fail-fast: false
name: "Check eclwatch and npm"
needs: pre_job
if: ${{ needs.pre_job.outputs.eclwatch }}
runs-on: ubuntu-20.04
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
with:
submodules: "recursive"
- uses: actions/setup-node@v2
- uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node }}
- name: Cache node modules
uses: actions/cache@v2
uses: actions/cache@v4
with:
path: ./esp/src/node_modules
key: npm-deps-${{ hashFiles('./esp/src/package-lock.json') }}
Expand Down
14 changes: 7 additions & 7 deletions .github/workflows/build-vcpkg.yml
Original file line number Diff line number Diff line change
Expand Up @@ -106,15 +106,15 @@ jobs:

- name: Checkout HPCC-Platform
if: ${{ contains(matrix.event_name, github.event_name) && needs.preamble.outputs.platform }}
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
ref: ${{ needs.preamble.outputs.community_ref }}
submodules: recursive
path: ${{ needs.preamble.outputs.folder_platform }}

- name: Checkout LN
if: ${{ matrix.ln && contains(matrix.event_name, github.event_name) }}
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
repository: ${{ github.repository_owner }}/LN
token: ${{ secrets.LNB_TOKEN }}
Expand Down Expand Up @@ -142,7 +142,7 @@ jobs:
- name: Set up Docker Buildx
if: ${{ contains(matrix.event_name, github.event_name) && needs.preamble.outputs.platform }}
id: buildx
uses: docker/setup-buildx-action@v2
uses: docker/setup-buildx-action@v3

- name: Pull previous images
run: |
Expand All @@ -151,7 +151,7 @@ jobs:

- name: Create Build Image
if: ${{ contains(matrix.event_name, github.event_name) && needs.preamble.outputs.platform }}
uses: docker/build-push-action@v4
uses: docker/build-push-action@v5
with:
builder: ${{ steps.buildx.outputs.name }}
file: ${{ needs.preamble.outputs.folder_platform }}/dockerfiles/vcpkg/${{ matrix.os }}.dockerfile
Expand Down Expand Up @@ -215,7 +215,7 @@ jobs:
# Common ---
- name: Upload error logs
if: ${{ failure() || cancelled() }}
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: ${{ matrix.os }}-${{ matrix.ln }}-${{ matrix.container }}-logs
path: ${{ needs.preamble.outputs.folder_build }}/**/*.log
Expand Down Expand Up @@ -326,7 +326,7 @@ jobs:

- name: Checkout HPCC-Platform
if: ${{ contains(matrix.event_name, github.event_name) && needs.preamble.outputs.platform }}
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
ref: ${{ needs.preamble.outputs.community_ref }}
submodules: recursive
Expand Down Expand Up @@ -360,7 +360,7 @@ jobs:

- name: Upload error logs
if: ${{ failure() || cancelled() }}
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: ${{ matrix.os }}--${{ matrix.ln }}-${{ matrix.container }}-logs
path: ./build/**/*.log
6 changes: 3 additions & 3 deletions .github/workflows/codeql-eclwatch.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,11 +51,11 @@ jobs:

steps:
- name: Checkout repository
uses: actions/checkout@v2
uses: actions/checkout@v4

# Initializes the CodeQL tools for scanning.
- name: Initialize CodeQL
uses: github/codeql-action/init@v1
uses: github/codeql-action/init@v3
with:
languages: ${{ matrix.language }}
# If you wish to specify custom queries, you can do so here or in a config file.
Expand All @@ -80,4 +80,4 @@ jobs:
# make release

- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@v1
uses: github/codeql-action/analyze@v3
2 changes: 1 addition & 1 deletion .github/workflows/jirabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
jirabot:
runs-on: ubuntu-20.04
steps:
- uses: "actions/setup-python@v2"
- uses: "actions/setup-python@v5"
with:
python-version: "3.8"
- name: "Install dependencies"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/nightly-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
run: |
echo "::set-output name=date::$(date +'%Y-%m-%d')"
- name: Checkout
uses: actions/checkout@v2
uses: actions/checkout@v4
- name: Build
uses: ./dockerfiles
with:
Expand Down
Loading
Loading