HPCC-30194 Nodejs v16 deprecation in 8.12.x build-assets fix

[Michael-Gardner]

Type of change:

• This change is a bug fix (non-breaking change which fixes an issue).
• This change is a new feature (non-breaking change which adds functionality).
• This change improves the code (refactor or other change that does not change the functionality)
• This change fixes warnings (the fix does not alter the functionality or the generated code)
• This change is a breaking change (fix or feature that will cause existing behavior to change).
• This change alters the query API (existing queries will have to be recompiled)

Checklist:

• My code follows the code style of this project.
  • My code does not create any new warnings from compiler, build system, or lint.
• The commit message is properly formatted and free of typos.
  • The commit message title makes sense in a changelog, by itself.
  • The commit is signed.
• My change requires a change to the documentation.
  • I have updated the documentation accordingly, or...
  • I have created a JIRA ticket to update the documentation.
  • Any new interfaces or exported functions are appropriately commented.
• I have read the CONTRIBUTORS document.
• The change has been fully tested:
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have checked that this change does not introduce memory leaks.
  • I have used Valgrind or similar tools to check for potential issues.
• I have given due consideration to all of the following potential concerns:
  • Scalability
  • Performance
  • Security
  • Thread-safety
  • Cloud-compatibility
  • Premature optimization
  • Existing deployed queries will not be broken
  • This change fixes the problem, not just the symptom
  • The target branch of this pull request is appropriate for such a change.
• There are no similar instances of the same problem that should be addressed
  • I have addressed them here
  • I have raised JIRA issues to address them separately
• This is a user interface / front-end modification
  • I have tested my changes in multiple modern browsers
  • The component(s) render as expected

Smoketest:

• Send notifications about my Pull Request position in Smoketest queue.
• Test my draft Pull Request.

Testing:

[github-actions]

https://track.hpccsystems.com/browse/HPCC-30194
Jira not updated (user does not match)

[Michael-Gardner]

Test build overnight here: https://github.com/Michael-Gardner/HPCC-Platform/actions/runs/7824175823

Should clean up the Nodejs 16 warnings for several of the Github actions we utilize in our builds.

@GordonSmith Following versions had to be bumped up for nodejs v20 on the github runner

ncipollo/[email protected]
actions/checkout@v4
docker/setup-buildx-action@v3
docker/login-action@v3
docker/build-push-action@v5

actions/setup-node@v4
actions/cache@v4
actions/upload-artifact@v4
actions/download-artifact@v4
github/codeql-action/init@v3 (v1 was using nodejs 12)
github/codeql-action/analyze@v3
actions/setup-python@v5

We might still need to make some additions once this gets merged and up-merged. Issue will likely remain in the 9.4.x branch.

[GordonSmith]

Can you also search for actions/setup-node and bump as well (and add "20" to the matrix)?

[Michael-Gardner]

@GordonSmith made the change you suggested and squashed the commits into one.

Example of ECLWatch test build with 20, 18, 16 https://github.com/hpcc-systems/HPCC-Platform/actions/runs/7847777505/job/21417491370?pr=18287

[ghalliday]

@Michael-Gardner please can you update the jira to summarise the change.