Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-27310 Fix Coverity scan issue in lnuid #18002

Merged
merged 2 commits into from
Oct 24, 2024
Merged

HPCC-27310 Fix Coverity scan issue in lnuid #18002

merged 2 commits into from
Oct 24, 2024

Conversation

timothyklemm
Copy link
Contributor

@timothyklemm timothyklemm commented Nov 8, 2023 •
edited
Loading

Borrow random_string logic from httplib to populate buffer if /dev/urandom cannot be opened or read.

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2023

https://track.hpccsystems.com/browse/HPCC-27310
Jira updated

@timothyklemm timothyklemm force-pushed the hpcc-27310-coverity_lnuid branch from 7c5f8be to 8b09b63 Compare October 17, 2024 18:00
@timothyklemm timothyklemm changed the base branch from candidate-9.4.x to master October 17, 2024 18:00
HPCC-27310 Fix Coverity scan issue in lnuid
3f1402e 
Borrow random_string logic from httplib to populate buffer if
/dev/urandom cannot be opened or read.

Signed-off-by: Tim Klemm <[email protected]>
@timothyklemm timothyklemm force-pushed the hpcc-27310-coverity_lnuid branch from 8b09b63 to 3f1402e Compare October 21, 2024 18:24
@timothyklemm
Copy link
Contributor Author

@ghalliday I'm not sure who the best person is to review this, but you did diagnose the issue in a Jira comment while posing an important question about how to address it.

ghalliday
ghalliday reviewed Oct 22, 2024
View reviewed changes
Copy link
Member

@ghalliday ghalliday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A reasonable fix - even though this should never happen. I would go for a simpler implementation though.

system/globalid/lnuid.cpp Outdated
OERRLOG("Could not read data from /dev/urandom");
auto randchar = []() -> char {
const char charset[] = "0123456789"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simpler is
return (char)rand() ;
there is no need for this to be human readable.

@ghalliday ghalliday merged commit 25d37ce into hpcc-systems:master Oct 24, 2024
50 checks passed
@ghalliday
Copy link
Member

I should have asked you to squash, but too late...

@github-actions GitHub Actions
Copy link

Jirabot Action Result:
Added fix version: 9.10.0
Workflow Transition: 'Resolve issue'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghalliday ghalliday ghalliday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timothyklemm @ghalliday