Merge pull request #18002 from timothyklemm/hpcc-27310-coverity_lnuid

HPCC-27310 Fix Coverity scan issue in lnuid Reviewed-by: Gavin Halliday <[email protected]> Merged-by: Gavin Halliday <[email protected]>
hpcc-systems · Oct 24, 2024 · 25d37ce · 25d37ce
2 parents ea449dc + 60ad141
commit 25d37ce
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/system/globalid/lnuid.cpp b/system/globalid/lnuid.cpp
@@ -94,8 +94,9 @@ namespace ln_uid {
         fp = fopen("/dev/urandom", "r");
         if (!fp || fread(&randomdata, 1, random_byte_count, fp) != random_byte_count)
         {
-            // Should never happen, but if it does log it and ignore
+            // Should never happen, but if it does log it and fallback
             OERRLOG("Could not read data from /dev/urandom");
+            std::generate_n(randomdata, random_byte_count, [](){ return char(rand()); });
         }
         if (fp)
             fclose(fp);