HPCC-31990 Add timeout to DNS lookups for soapcalls using a threadpool 3

Signed-off-by: M Kelly <[email protected]>

system/jlib/jsocket.cpp

@@ -478,13 +478,12 @@ static bool getAddressInfo(const char *name, unsigned *netaddr, bool okToLogErr)
 
 static CriticalSection queryDNSCS;
 
-class CAddrInfoThreadArgs : public CInterface, implements IInterface
+class CAddrInfoThreadArgs : public CInterface
 {
 public:
-    IMPLEMENT_IINTERFACE;
     StringAttr name;
     unsigned netaddr[4] = { 0, 0, 0, 0 };
-    bool result = false;
+    std::atomic<bool> result { false };
 
     CAddrInfoThreadArgs(const char *_name) : name(_name) { }
 };
@@ -529,19 +528,21 @@ class CAddrInfoFactory : public CInterface, public IThreadFactory
 
 static Owned<CAddrInfoFactory> addrInfoFactory;
 static Owned<IThreadPool> addrInfoPool;
+static std::atomic<bool> addrInfoPoolCreated { false };
 
 static bool useDNSTimeout()
 {
     queryTCPSettings();
     if (!disableDNSTimeout)
     {
-        if (!addrInfoPool)
+        if (!addrInfoPoolCreated.load())
         {
             CriticalBlock block(queryDNSCS);
-            if (!addrInfoPool)
+            if (!addrInfoPoolCreated.load())
             {
                 addrInfoFactory.setown(new CAddrInfoFactory);
                 addrInfoPool.setown(createThreadPool("AddrInfoPool", addrInfoFactory, true, nullptr, maxDNSThreads, 100000000));
+                addrInfoPoolCreated = true;
             }
         }
         return true;
@@ -558,10 +559,11 @@ MODULE_EXIT()
 {
     // NB: this (and other MODULE_EXITs) are not called for Thor and Roxie because they are
     //     stopped via SIGTERM signal and thus exit() and the atexit handlers are not called
-    if (addrInfoPool)
+    if (addrInfoPoolCreated.load())
     {
         addrInfoPool->joinAll(true);
         addrInfoPool.clear();
+        addrInfoPoolCreated = false;
     }
 }
 
@@ -3417,7 +3419,7 @@ static bool decodeNumericIP(const char *text,unsigned *netaddr)
 
 static void RecursionSafeLogErr(int ret, int ref, const char *msg, unsigned lineno, const char *name)
 {
-    static bool recursioncheck = false; // needed to stop error message recursing
+    static __thread bool recursioncheck = false; // needed to stop error message recursing
     if (!recursioncheck)
     {
         recursioncheck = true;
@@ -3451,6 +3453,7 @@ bool getAddressInfo(const char *name, unsigned *netaddr, bool okToLogErr)
             Sleep((10-retry)*100);
         else
         {
+            // use gai_strerror(ret) to get meaningful error text ?
             if (okToLogErr)
                 RecursionSafeLogErr(ret, 1, "getaddrinfo failed", __LINE__, name);
             return false;