HPCC-31990 Add timeout to DNS lookups for soapcalls using a threadpool 2

Signed-off-by: M Kelly <[email protected]>

system/jlib/jsocket.cpp

@@ -498,13 +498,12 @@ class CAddrPoolThread : public CInterface, implements IPooledThread
 
     virtual void init(void *param) override
     {
-        localAddrThreadInfo.set((CAddrInfoThreadArgs *)param);
+        localAddrThreadInfo.setown((CAddrInfoThreadArgs *)param);
     }
 
     virtual void threadmain() override
     {
         localAddrThreadInfo->result = getAddressInfo(localAddrThreadInfo->name.get(), localAddrThreadInfo->netaddr, false);
-        localAddrThreadInfo->Release();
     }
 
     virtual bool stop() override
@@ -542,7 +541,7 @@ static bool useDNSTimeout()
             if (!addrInfoPool)
             {
                 addrInfoFactory.setown(new CAddrInfoFactory);
-                addrInfoPool.setown(createThreadPool("AddrInfoPool", addrInfoFactory, false, nullptr, maxDNSThreads, 100000000));
+                addrInfoPool.setown(createThreadPool("AddrInfoPool", addrInfoFactory, true, nullptr, maxDNSThreads, 100000000));
             }
         }
         return true;
@@ -3606,6 +3605,8 @@ static bool lookupHostAddress(const char *name, unsigned *netaddr, unsigned time
                 return true;
             }
         }
+        // if join() returns false thread still running, but its detached,
+        // will terminate, release thread args and return to pool on its own ...
 
         StringBuffer emsg;
         emsg.appendf("getaddrinfo timed out (thread) (%d)", timeoutms);