Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Borrow form: percentage drop until liquidation #70

Closed
wants to merge 1 commit into from
Closed

Borrow form: percentage drop until liquidation #70

wants to merge 1 commit into from

Conversation

bowtiedpyro
Copy link
Collaborator

…lts in always true - so the percentage starts with an offset, which we dont want I assume

@vercel
Copy link

vercel bot commented Dec 9, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
evm-redesign ✅ Ready (Inspect) Visit Preview Dec 12, 2022 at 2:41PM (UTC)

@BowTiedHeron BowTiedHeron changed the title validate if there is newAdditionalDebt instead of NFT, otherwise resu… Borrow form: percentage drop until liquidation Dec 9, 2022
@BowTiedHeron BowTiedHeron changed the title Borrow form: percentage drop until liquidation [DRAFT] - Borrow form: percentage drop until liquidation Dec 9, 2022
@BowTiedHeron BowTiedHeron linked an issue Dec 9, 2022 that may be closed by this pull request
Borrow page: integrate liquidation price and make sure calc is right #68
Open
@bowtiedpyro @BowTiedHeron
validate if there is newAdditionalDebt instead of NFT, otherwise resu…
81efe23 
…lts in always true - so the percentage starts with an offset, which we dont want I assume
@BowTiedHeron BowTiedHeron force-pushed the 68-borrow-page-integrate-liquidation-price-and-make-sure-calc-is-right branch from 1dc78c1 to 81efe23 Compare December 12, 2022 14:39
@BowTiedHeron BowTiedHeron changed the title [DRAFT] - Borrow form: percentage drop until liquidation Borrow form: percentage drop until liquidation Dec 12, 2022
@BowTiedFirefox
Copy link
Collaborator

are you sure the target branch is correct?

@BowTiedHeron BowTiedHeron deleted the 68-borrow-page-integrate-liquidation-price-and-make-sure-calc-is-right branch March 11, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BowTiedFirefox BowTiedFirefox BowTiedFirefox left review comments

@BowTiedHeron BowTiedHeron BowTiedHeron left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Borrow page: integrate liquidation price and make sure calc is right
3 participants
@bowtiedpyro @BowTiedFirefox @BowTiedHeron