Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Borrow page: integrate liquidation price and make sure calc is right #68

Open
BowTiedHeron opened this issue Dec 9, 2022 · 2 comments
Open

Borrow page: integrate liquidation price and make sure calc is right #68

BowTiedHeron opened this issue Dec 9, 2022 · 2 comments
Assignees
@bowtiedpyro

Comments

@BowTiedHeron
Copy link
Collaborator

BowTiedHeron commented Dec 9, 2022 •
edited
Loading

See: d50c67e

PR into final-style-fixes if it hasnt been merged into main yet
see PR: #65
@bowtiedpyro
Copy link
Collaborator

When starting the slider, the numbers update correctly - however, the starting point (percentage wise, see screen) is off.
The liquidation price equals the new liquidation price but the percentage is already -80%.
Screenshot 2022-12-09 at 10 40 04

@bowtiedpyro
Copy link
Collaborator

@BowTiedHeron see this push fixes it:
1dc78c1

@BowTiedHeron BowTiedHeron linked a pull request Dec 9, 2022 that will close this issue
Borrow form: percentage drop until liquidation #70
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bowtiedpyro bowtiedpyro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Borrow form: percentage drop until liquidation honey-protocol/honey-frontend-evm
2 participants
@BowTiedHeron @bowtiedpyro