Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize(cli): should cleanup global pollution after render #261

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

hikerpig
Copy link
Owner

@hikerpig hikerpig commented Feb 28, 2024

A quick but not perfect fix for #237

Copy link

vercel bot commented Feb 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pintorajs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2024 2:10pm

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 96.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 91.82%. Comparing base (87f80b1) to head (8a148a0).
Report is 137 commits behind head on master.

❗ Current head 8a148a0 differs from pull request most recent head 2fed43a. Consider uploading reports for the commit 2fed43a to get more accurate results

Files Patch % Lines
packages/pintora-cli/src/render.ts 96.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #261      +/-   ##
==========================================
+ Coverage   91.06%   91.82%   +0.76%     
==========================================
  Files          69       88      +19     
  Lines        3994     5165    +1171     
  Branches      762      915     +153     
==========================================
+ Hits         3637     4743    +1106     
- Misses        357      422      +65     
Flag Coverage Δ
unittests 91.82% <96.00%> (+0.76%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hikerpig hikerpig force-pushed the fix-cli-global-polution branch from 8a148a0 to 2fed43a Compare February 28, 2024 14:08
@hikerpig hikerpig force-pushed the fix-cli-global-polution branch from 2fed43a to 4b3f350 Compare February 28, 2024 14:09
@hikerpig hikerpig merged commit 3984345 into master Feb 28, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant