Add a waterfall to avoid parallel renders #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This does not work with a proper build.. There would need to have yet another trick to keep unbuilt the two files in question in the rollup configuration of the vite configuration of the astro configuration... I think I'm going to drop this idea. |
tex0l
changed the title
|
Instead of forking the process, we'll rely on v0.7.2 (see hikerpig/pintora#261) which cleans up the patches it made in the globals, and waterfall execution so that two runs of render do not collide with each other. We also need to expose the waterfall function so that function which need a clean env can wait for the env to be cleaned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ugly workaround for #4