Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Dropdowns):Refactor the components across the hawtio to use the PF5 dropdown instead of old deprecate ones #960

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

mmelko
Copy link
Collaborator

@mmelko mmelko commented May 30, 2024

This PR gets rid of deprecated Dropdown components from the PF4 which is now at '@patternfly/react-core/deprecated' with the recent ones.
branch: jsolovjo:e2e-tests-fix-pf5-dropdowns

related to: #477

Copy link

github-actions bot commented May 30, 2024

Test Results

  8 files  ±0    8 suites  +1   36m 32s ⏱️ - 2h 48m 12s
 65 tests ±0   63 ✅ + 63   2 💤 + 2  0 ❌  -  65 
463 runs  +1  439 ✅ +439  24 💤 +24  0 ❌  - 462 

Results for commit 358cc63. ± Comparison against base commit e761568.

♻️ This comment has been updated with latest results.

@hawtio-ci
Copy link

hawtio-ci bot commented May 30, 2024

Test results

Run attempt: 1876
Detailed summary

NAME TESTS PASSED ✅ SKIPPED 💤 FAILED ❌ ERRORS 🚫 TIME 🕖
results-quarkus-node(18)-java(17)-firefox 66 63 3 0 0 310.308
results-quarkus-node(18)-java(21)-firefox 66 63 3 0 0 314.925
results-quarkus-node(20)-java(17)-firefox 66 63 3 0 0 315.346
results-quarkus-node(20)-java(21)-firefox 66 63 3 0 0 312.315
results-springboot-node(18)-java(17)-firefox 66 62 4 0 0 308.336
results-springboot-node(18)-java(21)-firefox 66 62 4 0 0 311.868
results-springboot-node(20)-java(17)-firefox 66 62 4 0 0 312.675
results-springboot-node(20)-java(21)-firefox 1 1 0 0 0 7.168

…the PF5 dropdown instead of old deprecate ones
@mmelko mmelko force-pushed the pf5-dropdows-migration branch from 0efb808 to 358cc63 Compare June 6, 2024 13:44
@tadayosi
Copy link
Member

tadayosi commented Jun 7, 2024

Please look at hawtio/hawtio#3514 first, as unless we fix Juri's E2E at hawtio/hawtio we won't be able to go anywhere further.

@mmelko mmelko merged commit e23033b into hawtio:main Jun 11, 2024
15 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants