Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Bump GHC 9.8.4 + add bullseye image for 9.8.4 #143

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

Totto16
Copy link
Contributor

@Totto16 Totto16 commented Dec 16, 2024

Bumping 9.8.2 to 9.8.4.
Adding a bullseye variant of version 9.8.4 based on #134

Stackage LTS 23 released recently, which needs ghc 9.8.4

Info

Download: https://downloads.haskell.org/ghc/9.8.4/
Blog: https://www.haskell.org/ghc/blog/20241202-ghc-9.8.4-released.html

Copy link
Collaborator

@jhrcek jhrcek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM

@Totto16
Copy link
Contributor Author

Totto16 commented Dec 16, 2024

As far as I can see, the CI failures are not directly related to this PR

@jhrcek
Copy link
Collaborator

jhrcek commented Dec 17, 2024

@Totto16 I'm addressing the CI failures here: #144
Let me merge that first before merging this PR.

However I just realized now that docker-library/official-images (https://github.com/docker-library/official-images/blob/master/library/haskell) no longer accepts buster (debian 10) based images (see #132 (comment)) because buster is past the end of life.

So if you really want an official haskell image with ghc 8.4 support, we'll have to migrate the dockerfiles to be based on bullseye (debian 11) at least. Do you want to take a stab at that? You can find some inspiration in similar PRs where we added bullseye support for ghc 9.6 (#137) and 9.10 (#134). If you don't, I can take a stab at that later this week.

@Totto16
Copy link
Contributor Author

Totto16 commented Dec 17, 2024

@Totto16 I'm addressing the CI failures here: #144 Let me merge that first before merging this PR.

Ah I see, 👍🏼

However I just realized now that docker-library/official-images (https://github.com/docker-library/official-images/blob/master/library/haskell) no longer accepts buster (debian 10) based images (see #132 (comment)) because buster is past the end of life.

So if you really want an official haskell image with ghc 8.4 support, we'll have to migrate the dockerfiles to be based on bullseye (debian 11) at least. Do you want to take a stab at that? You can find some inspiration in similar PRs where we added bullseye support for ghc 9.6 (#137) and 9.10 (#134). If you don't, I can take a stab at that later this week.

I can do that. 👍🏼

I don't use debian that much, so I didn't know the newest version was already 12, and 11 isn't even the newest 😓
But the release supports deb11 for both arm64 and x86_64 but deb12 only for x86_64, which is interesting, as deb12 is out since "10 June 2023" and I wonder why there are releases with the EOL distro deb10 and no for the newest one 😓

@Totto16
Copy link
Contributor Author

Totto16 commented Dec 17, 2024

As far as I see, the old buster images are still bumped, so that we have e.g. 9.6.6 in all 2 variants of buster and bullseye, so I would say, that the old should also be updated to 9.8.4, so I didn't remove the first commit but add the new images based on bullseye based on the 9.10.1 images

@Totto16 Totto16 changed the title Bump GHC 9.8.4 feat: Bump GHC 9.8.4 + add bullseye image for 9.8.4 Dec 17, 2024
@Totto16
Copy link
Contributor Author

Totto16 commented Dec 17, 2024

Should I also bump cabal to 3.12 ?
like you said here
#141 (comment)

@jhrcek
Copy link
Collaborator

jhrcek commented Dec 17, 2024

I would say, that the old should also be updated to 9.8.4, so I didn't remove the first commit but add the new images based on bullseye based on the 9.10.1 images

Adding separate bullseye images (and keeping buster ones around) makes sense to me.
I don't have historical context, but is seems to be precedent in this repo, so let's just carry on with it.

Should I also bump cabal to 3.12 ?

Let's keep the PR focused on ghc 9.8.4 upgrade and let's do cabal 3.12 upgrade separately (because ghc 9.8 should work fine with cabal 3.10 based on its release page)

@develop7
Copy link
Collaborator

Should I also bump cabal to 3.12 ?

I second @jhrcek, let's leave it as is for now

Copy link
Collaborator

@develop7 develop7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging

@develop7 develop7 merged commit 36206e8 into haskell:master Dec 17, 2024
@Totto16 Totto16 deleted the ghc-9.8.4 branch December 17, 2024 15:29
@Totto16 Totto16 mentioned this pull request Dec 17, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants