-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Bump GHC 9.8.4 + add bullseye image for 9.8.4 #143
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. LGTM
As far as I can see, the CI failures are not directly related to this PR |
@Totto16 I'm addressing the CI failures here: #144 However I just realized now that docker-library/official-images (https://github.com/docker-library/official-images/blob/master/library/haskell) no longer accepts buster (debian 10) based images (see #132 (comment)) because buster is past the end of life. So if you really want an official haskell image with ghc 8.4 support, we'll have to migrate the dockerfiles to be based on bullseye (debian 11) at least. Do you want to take a stab at that? You can find some inspiration in similar PRs where we added bullseye support for ghc 9.6 (#137) and 9.10 (#134). If you don't, I can take a stab at that later this week. |
Ah I see, 👍🏼
I can do that. 👍🏼 I don't use debian that much, so I didn't know the newest version was already 12, and 11 isn't even the newest 😓 |
As far as I see, the old buster images are still bumped, so that we have e.g. 9.6.6 in all 2 variants of buster and bullseye, so I would say, that the old should also be updated to 9.8.4, so I didn't remove the first commit but add the new images based on bullseye based on the 9.10.1 images |
Should I also bump cabal to 3.12 ? |
Adding separate bullseye images (and keeping buster ones around) makes sense to me.
Let's keep the PR focused on ghc 9.8.4 upgrade and let's do cabal 3.12 upgrade separately (because ghc 9.8 should work fine with cabal 3.10 based on its release page) |
I second @jhrcek, let's leave it as is for now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, merging
Bumping 9.8.2 to 9.8.4.
Adding a bullseye variant of version 9.8.4 based on #134
Stackage LTS 23 released recently, which needs ghc 9.8.4
Info
Download: https://downloads.haskell.org/ghc/9.8.4/
Blog: https://www.haskell.org/ghc/blog/20241202-ghc-9.8.4-released.html