Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two Errors I encountered while working on #145 and #143
ubuntu-latest
github action runners, which used to beubuntu-24.04
but is going to be switched toubuntu-24.04
soon (see Ubuntu-latest workflows will use Ubuntu-24.04 image actions/runner-images#10636)This produces a ton of warnings:
in the CI runs, and it's generally a better idea to be explicit about that.
Since we don't use a ton of special features or packages, that may break from that transition, it is a good idea to use the newer one (
ubuntu-24.04
). If you paid close attention to recent CI runs, some / nearly all already usedubuntu-24.04
.This is actually possible, by making checks a fatal error instead of a warning. See here
I also skipped one check:
SecretsUsedInArgOrEnv
, since this check detects all GPG KEYARG
directives as an error, which they aren't.I fixed all remaining errors, which only were
LegacyKeyValueFormat