Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Update CI #146

Merged
merged 4 commits into from
Dec 18, 2024
Merged

Feat: Update CI #146

merged 4 commits into from
Dec 18, 2024

Conversation

Totto16
Copy link
Contributor

@Totto16 Totto16 commented Dec 17, 2024

This fixes two Errors I encountered while working on #145 and #143

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

in the CI runs, and it's generally a better idea to be explicit about that.

Since we don't use a ton of special features or packages, that may break from that transition, it is a good idea to use the newer one (ubuntu-24.04). If you paid close attention to recent CI runs, some / nearly all already used ubuntu-24.04.

  • I saw some docker build warnings while I worked on feat: Add GHC 9.12.1 #145 and maybe they can be reported by hadolint already. So I looked at the used version in the CI and it was outdated, so hopefully some new errors / warnings will be found by the newer action (I doubt it, as my local hadolint installation didn't warn me about these warnings, but lets' see 🤷🏼‍♂️ )

This is actually possible, by making checks a fatal error instead of a warning. See here

I also skipped one check: SecretsUsedInArgOrEnv, since this check detects all GPG KEY ARGdirectives as an error, which they aren't.
I fixed all remaining errors, which only were LegacyKeyValueFormat

this comes with some improvements and a new hadolint version
use explicitly tagged image instead of ubuntu-latest, as that may be changed and therefore potentially make the ci fail without any changes and only the passing of time
skip the check SecretsUsedInArgOrEnv, since it is a false positive in all cases in this repo
Copy link
Collaborator

@develop7 develop7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for coming forward, looks good

@develop7 develop7 merged commit 018abed into haskell:master Dec 18, 2024
28 checks passed
@Totto16 Totto16 deleted the update-ci branch December 18, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants