Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change profile_url to absolute_url and include in callerid API #1906

Merged
merged 6 commits into from
Oct 25, 2023
Merged

Change profile_url to absolute_url and include in callerid API #1906

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4c81989
Added urlname to the callerid API
djamg Oct 18, 2023
5c9fd1d
added profile_url instead of urlname
djamg Oct 20, 2023
3cedd79
Updated tests
djamg Oct 20, 2023
bac2704
Replace profile_url with existing absolute_url
jace Oct 25, 2023
f4b66b5
Use standard name and title properties
jace Oct 25, 2023
8286b6e
Linter fix
jace Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions funnel/views/api/support.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ def support_callerid(number: str) -> tuple[dict[str, Any], int]:
info['account'] = {
'title': user_phone.account.fullname,
'name': user_phone.account.username,
'urlname': user_phone.account.urlname,
djamg marked this conversation as resolved.
Show resolved Hide resolved
}
return {'status': 'ok', 'result': info}, 200
# TODO: Check in TicketParticipant.phone
Loading