Change profile_url to absolute_url and include in callerid API #1906

djamg · 2023-10-18T18:39:34Z

No description provided.

funnel/views/api/support.py

jace

Please confirm account.profile_url returns a URL regardless of the account state. If so, this is good to merge.

Added urlname to the callerid API

4c81989

djamg requested a review from jace October 18, 2023 18:39

jace requested changes Oct 19, 2023

View reviewed changes

funnel/views/api/support.py Outdated Show resolved Hide resolved

added profile_url instead of urlname

5c9fd1d

jace previously approved these changes Oct 20, 2023

View reviewed changes

Updated tests

3cedd79

djamg dismissed jace’s stale review via 3cedd79 October 20, 2023 06:34

jace previously approved these changes Oct 20, 2023

View reviewed changes

Replace profile_url with existing absolute_url

bac2704

jace dismissed their stale review via bac2704 October 25, 2023 06:28

jace changed the title ~~Added urlname to the callerid API~~ Change profile_url to absolute_url and include in callerid API Oct 25, 2023

jace added 2 commits October 25, 2023 12:09

Use standard name and title properties

f4b66b5

Linter fix

8286b6e

jace approved these changes Oct 25, 2023

View reviewed changes

vidya-ram approved these changes Oct 25, 2023

View reviewed changes

jace merged commit 1d9106b into main Oct 25, 2023
24 of 25 checks passed

jace deleted the callerid-api-update branch October 25, 2023 10:18

Provide feedback