-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tcgaPipeline #96
base: devel
Are you sure you want to change the base?
tcgaPipeline #96
Conversation
Codecov Report
@@ Coverage Diff @@
## master #96 +/- ##
========================================
Coverage ? 38.3%
========================================
Files ? 32
Lines ? 3428
Branches ? 0
========================================
Hits ? 1313
Misses ? 2115
Partials ? 0
Continue to review full report at Codecov.
|
Alright I think this is all set. Please merge. |
addendum: check it out, now my pull INCREASES overall unit test coverage. How about that! |
update: noobPipeline() is now tcgaPipeline(), and getSnpBeta() is now a generic. Documentation and tests updated to reflect these changes. This is the enemy of the perfect. |
I saw that and I liked it.
…On Thu, Apr 20, 2017 at 3:58 PM, Tim Triche, Jr. ***@***.***> wrote:
addendum: check it out, now my pull INCREASES overall unit test coverage.
How about that!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#96 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEuhn1kcbZD6S4T1rlytWr3nosjCD9Zdks5rx7jvgaJpZM4MJKVO>
.
|
Conflicts: DESCRIPTION
Updated DESCRIPTION to remove conflict. Unclear how this could affect Travis coverage... |
nb. The Travis error is a timeout from taking too long to load the annotation libraries required to run mapToGenome() in the test. Not much I can do about this without dropping the unit test. |
I got tired of writing the same old crap when what I really wanted was to scan an entire directory of IDATs into a GenomicRatioSet with CN values. So here's the fix. (Edit: changed name to tcgaPipeline.)