Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tcgaPipeline #96

Open
wants to merge 18 commits into
base: devel
Choose a base branch
from
Open

tcgaPipeline #96

wants to merge 18 commits into from

Conversation

ttriche
Copy link
Contributor

@ttriche ttriche commented Feb 22, 2017

I got tired of writing the same old crap when what I really wanted was to scan an entire directory of IDATs into a GenomicRatioSet with CN values. So here's the fix. (Edit: changed name to tcgaPipeline.)

grSet <- tcgaPipeline(read.metharray.exp(base="."))
show(grSet)
# class: GenomicRatioSet 
# dim: 866836 1 
# metadata(1): SNPs
# assays(2): Beta CN
# ...

@codecov-io
Copy link

codecov-io commented Apr 12, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@8d19249). Click here to learn what that means.
The diff coverage is 82.22%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master     #96   +/-   ##
========================================
  Coverage          ?   38.3%           
========================================
  Files             ?      32           
  Lines             ?    3428           
  Branches          ?       0           
========================================
  Hits              ?    1313           
  Misses            ?    2115           
  Partials          ?       0
Impacted Files Coverage Δ
R/rgset.R 55.35% <100%> (ø)
R/tcgaPipeline.R 100% <100%> (ø)
R/generics.R 83.33% <100%> (ø)
R/grset.R 50% <52.94%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d19249...3f40959. Read the comment docs.

@ttriche
Copy link
Contributor Author

ttriche commented Apr 12, 2017 via email

@ttriche
Copy link
Contributor Author

ttriche commented Apr 20, 2017

Alright I think this is all set. Please merge.

@ttriche
Copy link
Contributor Author

ttriche commented Apr 20, 2017

addendum: check it out, now my pull INCREASES overall unit test coverage. How about that!

@ttriche ttriche changed the title noobPipeline tcgaPipeline May 10, 2017
@ttriche
Copy link
Contributor Author

ttriche commented May 10, 2017

update: noobPipeline() is now tcgaPipeline(), and getSnpBeta() is now a generic. Documentation and tests updated to reflect these changes. This is the enemy of the perfect.

@kasperdanielhansen
Copy link
Collaborator

kasperdanielhansen commented May 11, 2017 via email

@ttriche
Copy link
Contributor Author

ttriche commented Jan 10, 2018

Updated DESCRIPTION to remove conflict. Unclear how this could affect Travis coverage...

@ttriche
Copy link
Contributor Author

ttriche commented Jan 14, 2018

nb. The Travis error is a timeout from taking too long to load the annotation libraries required to run mapToGenome() in the test. Not much I can do about this without dropping the unit test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants