Generalize get_conditions of player state

client/characters/src/items/inventory.rs

@@ -78,7 +78,7 @@ fn get_recursive_effects(item_id: &ItemId, character: &Character) -> Stats {
 }
 
 // Could move elsewhere if need be. Written this way to handle duplicates.
-fn filter_out<T: PartialEq + Clone>(container: &Vec<T>, to_remove: &Vec<T>) -> Result<Vec<T>, ()> {
+fn filter_out<T: PartialEq + Clone>(container: &[T], to_remove: &[T]) -> Result<Vec<T>, ()> {
     let mut temp = container.to_owned();
 
     for dependency in to_remove {

client/characters/src/moves/move_situation.rs

@@ -14,7 +14,7 @@ pub struct Situation<'a> {
     pub grounded: bool,
     pub properties: &'a Properties,
     pub parser: &'a InputParser,
-    pub conditions: &'a Vec<StatusCondition>,
+    pub conditions: Vec<StatusCondition>,
     pub current_frame: usize,
 }
 
@@ -170,7 +170,7 @@ mod test {
                 properties: &self.properties,
                 parser: &self.parser,
                 current_frame: self.current_frame,
-                conditions: &self.conditions,
+                conditions: self.conditions.clone(),
             }
             .new_fcs()
         }

client/lib/src/player/move_activation/mod.rs

@@ -122,7 +122,7 @@ pub(super) fn raw_or_link(
                         properties,
                         parser,
                         current_frame: clock.frame,
-                        conditions: state.get_conditions(),
+                        conditions: state.get_conditions().to_owned(),
                     },
                 )
                 .into_iter()
@@ -167,7 +167,7 @@ pub(super) fn special_cancel(
                             properties,
                             parser,
                             current_frame: clock.frame,
-                            conditions: state.get_conditions(),
+                            conditions: state.get_conditions().to_owned(),
                         },
                     )
                     .into_iter()

client/lib/src/player/move_advancement.rs

@@ -16,7 +16,7 @@ pub(super) fn move_advancement(clock: Res<Clock>, mut query: Query<PlayerQuery>)
             properties: &player.properties,
             parser: &player.input_parser,
             current_frame: clock.frame,
-            conditions: &player.state.get_conditions().to_owned(), // There is probably a smarter way to do this, but I can't really be bothered to think of it at this moment
+            conditions: player.state.get_conditions().to_owned(), // There is probably a smarter way to do this, but I can't really be bothered to think of it at this moment
         };
 
         player.state.proceed_move(situation);

client/player_state/src/player_state.rs

@@ -266,7 +266,7 @@ impl PlayerState {
     pub fn add_condition(&mut self, condition: StatusCondition) {
         self.conditions.push(condition);
     }
-    pub fn get_conditions(&self) -> &Vec<StatusCondition> {
+    pub fn get_conditions(&self) -> &[StatusCondition] {
         &self.conditions
     }
     pub fn has_flag(&self, condition: StatusFlag) -> bool {