Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github-issues (html and scss files) updated to resolve visual issues. #933

Closed
wants to merge 9 commits into from
Closed

github-issues (html and scss files) updated to resolve visual issues. #933

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
95bc3c9
github-issues (html and scss files) updated to resolve visual issues.
alyssabenipayo Jan 11, 2021
c94b7f3
visual issue resolved
alyssabenipayo Jan 18, 2021
d16350c
Merge branch 'gh-pages' into the-most-out-of-gh_hflasite
alyssabenipayo Jan 18, 2021
df8cdc0
Restructured github-issue-guide file to utilize classes from guide-pa…
alyssabenipayo Jan 31, 2021
596ee4d
Merge branch 'gh-pages' into the-most-out-of-gh_hflasite
alyssabenipayo Jan 31, 2021
f21d881
Updated Getting the Most Out of GitHub Guide Page css and html files …
alyssabenipayo Feb 21, 2021
7b2170f
Merge branch 'gh-pages' into the-most-out-of-gh_hflasite
alyssabenipayo Feb 21, 2021
96639df
Updated text size and alignments
alyssabenipayo Feb 21, 2021
ea010cc
Merge branch 'gh-pages' into the-most-out-of-gh_hflasite
alyssabenipayo Feb 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions _guide-pages/github-issues.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
- name: Member Analytics
link: '#member-analytics'
card-type: guide-page
status: coming-soon
status: active
display: true
category: development
svg: svg/toolkit-default-card-image.svg
Expand All @@ -28,7 +28,7 @@ <h5>An effective Hack for LA Github issue includes the following components:</h5
<p><em>Click any section link below to jump down to its description</em></p> <br>

<div class="overlay-links">
<img class="screenshot" src="../assets/images/guides/github-issue/good-issue-example.svg" >
<img class="overlay-links-img" src="../assets/images/guides/github-issue/good-issue-example.svg" >
<!-- Arrows and Overlay Text Links -->
<!-- RIGHT SIDE LINKS -->
<img class="assignees" src="../assets/images/guides/pink-pointer.svg">
Expand Down
10 changes: 5 additions & 5 deletions _sass/components/guide-pages/github-issue-guide.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,12 +67,12 @@
// VARIABLES FOR OVERLAY LINKS
@mixin right-overlay {
position: absolute;
left: 90%;
width: 7%;
left: 94%;
width: 7%;
}
@mixin right-text-overlay {
position: absolute;
left: 97.5%;
left: 102%;
}

@mixin left-overlay {
Expand All @@ -92,11 +92,11 @@
//RIGHT SIDE LINKS
.assignees {
@include right-overlay;
top: 17.5%;
top: 16%;

+ h4 {
@include right-text-overlay;
top: 17.5%;
top: 16%;
}
}

Expand Down