Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github-issues (html and scss files) updated to resolve visual issues. #933

Closed
wants to merge 9 commits into from
Closed

github-issues (html and scss files) updated to resolve visual issues. #933

wants to merge 9 commits into from

Conversation

abenipa3
Copy link
Member

@abenipa3 abenipa3 commented Jan 12, 2021

  • Updated github-issues-guide.scss and github-issues.html to resolve visual issues.
  • Updated the card to reflect live status.

Fixes #794

UPDATE 4:04 PM 1/11/21: I've just identified a new visual issue after reviewing it in iPad mode. Will update once it's resolved. Thanks.

@abenipa3 abenipa3 requested a review from drubgrubby January 18, 2021 00:56
@abenipa3
Copy link
Member Author

Fixes #794

  • Visual issue resolved. Ready for review.

Copy link
Member

@drubgrubby drubgrubby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alyssabenipayo - Good work on getting the flags to be more stable. Hopefully at a developers' meeting you can explain your solution.

Unfortunately, it seems that while the iPad version is now fixed, on the iPhone version the flags are now pushed over the top of the things they are flagging.

Screen Shot 2021-01-18 at 7 05 23 AM

On the current version that's live on the site the mobile version seems okay.

Perhaps you can play with the css media query (or something) to make it so both the tablet and mobile versions track correctly.

@abenipa3
Copy link
Member Author

@drubgrubby - Thank you for your feedback.

I might be late in attending tonight's meeting -- going to help my parents out tonight and not sure when I'll be back.

In the meantime, here's a brief explanation of the solution:

  • The @ mixins for the guide arrows in _guide-pages.scss are reusable, which makes it easier to resolve the visual issue as long as we call the correct class.
  • In this case, the class "overlay-links-img" is the class we used so that the arrows will connect with the image.
    image
  • Initially, we had "screenshot" as the class, which did not work.
    image

I'll be more than happy to elaborate either tonight's meeting or on Sunday. Will continue to experiment with the media query.

Thanks.

@abenipa3 abenipa3 requested a review from daniellex0 February 21, 2021 08:35
@abenipa3
Copy link
Member Author

Redesigning guide pages. #1085

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting the Most out of Github Issues Guide
3 participants