Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get in touch anchor tag added in contact-us.html #3457

Merged

Conversation

CalvinTan607
Copy link
Contributor

@CalvinTan607 CalvinTan607 commented Aug 10, 2022

Fixes #3023

What changes did you make and why did you make them ?

-added anchor tag which links to Get in Touch section of homepage

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visual changes to website

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b CalvinTan607-add-anchor-tag-3023 feature-homepage-launch
git pull https://github.com/CalvinTan607/website.git add-anchor-tag-3023

@arpitapandya
Copy link
Member

Availability: 6 Hours
ETA: EOD 2022-08-09

@JessicaLucindaCheng JessicaLucindaCheng linked an issue Aug 10, 2022 that may be closed by this pull request
10 tasks
Copy link
Member

@arpitapandya arpitapandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes looks correct! Great job! @CalvinTan607

Though, There are dependency labels missing to this PR

@lilyarj lilyarj self-requested a review August 10, 2022 20:38
@lilyarj
Copy link
Member

lilyarj commented Aug 10, 2022

ETA: 8/10
Availability: 2hrs

Copy link
Member

@lilyarj lilyarj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good!

@Wny-Duong Wny-Duong merged commit 1c72b8a into hackforla:feature-homepage-launch Aug 12, 2022
@JessicaLucindaCheng JessicaLucindaCheng added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Home page https://www.hackforla.org/ Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Feature Branch Requires Branching off a Feature Branch instead of gh-pages size: 0.5pt Can be done in 3 hours or less labels Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Feature Branch Requires Branching off a Feature Branch instead of gh-pages P-Feature: Home page https://www.hackforla.org/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
Development

Successfully merging this pull request may close these issues.

Homepage redesign: Add anchor to Get In Touch section
5 participants