Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize how 'Overview' links open pdf files #2211

Closed
15 tasks done
macho-catt opened this issue Aug 31, 2021 · 8 comments
Closed
15 tasks done

Standardize how 'Overview' links open pdf files #2211

macho-catt opened this issue Aug 31, 2021 · 8 comments
Assignees
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue epic Feature: Infrastructure For changes on site technical architecture P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours Status: Updated No blockers and update is ready for review

Comments

@macho-catt
Copy link
Member

macho-catt commented Aug 31, 2021

Dependency

Overview

As a user, clicking on the 'Overview' link for each project page should act the same way. Currently, the 'Overview' links for each project act differently. Clicking the link should open a new tab to the pdf file directly. We will convert each action item into an issue and create a pull request to close the corresponding issue. Then, as a last action item, we will check all overview links appear on the homepage to make sure they are all working the same way.

Details

When clicking the 'Overview' link, each project page acts differently. Some open to a google docs page, others open to a github page that hosts the pdf file, and another downloads the pdf file locally to the machine. There needs to be a standard in how the pdf files open. Developers decided during the backend meeting that pdfs should be opened as a separate tab to the file directly, since modern browsers have the ability to view pdfs.

Example:
How pdf files currently open
How pdf files should open

The process for a developer would involve:

  • Use the newly created directory for pdf files: /assets/pdfs
  • Place a copy of a project's pdf overview file into the /assets/pdfs directory
  • Change the 'Overview' link for a project to point to the pdf file living under /assets/pdfs
  • Ensure that the links in both the home page and the project's dedicated page open the pdf file properly after the change

Action Items

  • Check all overview links that appear on the Projects page to make sure they are all working the same way and opening the pdfs the same way
    • If the overview links do not work the same way nor open the pdfs the same way, let a Merge Team member or Technical Lead know so that they can help you with writing issues to fix the overview links.
    • If the overview links all work the same way and open the pdfs the same way, add a new comment to the homepage launch issue homepage launch #2481 stating all the overview links work correctly and adding this link to your comment: Standardize how 'Overview' links open pdf files #2211

Resources/Instructions

How pdf files currently open
How pdf files should open
Project Page
Each individual landing page for affected projects: 100 Automations as an example
Location for pdf files
Jekyll Static Files

@macho-catt macho-catt added role: front end Tasks for front end developers Complexity: Large Feature: Infrastructure For changes on site technical architecture Ready for Prioritization labels Aug 31, 2021
@github-actions

This comment was marked as resolved.

@ExperimentsInHonesty

This comment was marked as resolved.

@macho-catt

This comment was marked as resolved.

@SAUMILDHANKAR SAUMILDHANKAR added Dependency An issue is blocking the completion or starting of another issue P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 1pt Can be done in 4-6 hours Feature: Infrastructure For changes on site technical architecture and removed Collaborative Work Feature: Infrastructure For changes on site technical architecture Feature: Refactor HTML size: 8pt Can be done in 31-48 hours Dependency An issue is blocking the completion or starting of another issue labels Mar 19, 2022
@ExperimentsInHonesty ExperimentsInHonesty added Complexity: Small Take this type of issues after the successful merge of your second good first issue and removed Complexity: Large labels Apr 2, 2022
@JessicaLucindaCheng

This comment was marked as outdated.

@abdiaz2018 abdiaz2018 self-assigned this Sep 8, 2022
@github-actions

This comment was marked as outdated.

@abdiaz2018 abdiaz2018 removed their assignment Sep 8, 2022
@abdiaz2018 abdiaz2018 self-assigned this Sep 16, 2022
@github-actions
Copy link

Hi @abdiaz2018, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@abdiaz2018
Copy link
Member

abdiaz2018 commented Sep 16, 2022

Availability: 3 hours
ETA: Thursday night

@github-actions github-actions bot added the Status: Updated No blockers and update is ready for review label Sep 16, 2022
@JessicaLucindaCheng
Copy link
Member

Developer has added the following comment in the homepage launch issue: #2481 (comment). Thus, I'm closing this issue as completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue epic Feature: Infrastructure For changes on site technical architecture P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours Status: Updated No blockers and update is ready for review
Projects
Development

No branches or pull requests

7 participants