Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update how 'Overview' link opens for Access The Data #2234

Closed
3 tasks done
Tracked by #2211
macho-catt opened this issue Sep 8, 2021 · 1 comment · Fixed by #2549
Closed
3 tasks done
Tracked by #2211

Update how 'Overview' link opens for Access The Data #2234

macho-catt opened this issue Sep 8, 2021 · 1 comment · Fixed by #2549
Assignees
Labels
Feature: Refactor HTML good first issue Good for newcomers role: front end Tasks for front end developers size: missing Status: Updated No blockers and update is ready for review

Comments

@macho-catt
Copy link
Member

macho-catt commented Sep 8, 2021

Overview

As a user, clicking on the 'Overview' link for the Access The Data project should open a new tab to the pdf file directly. This is made as an action item of #2211

Details

When clicking the 'Overview' link, each project page acts differently. Some open to a google docs page, others open to a github page that hosts the pdf file, and another downloads the pdf file locally to the machine. There needs to be a standard in how the pdf files open. Developers decided during the backend meeting that pdfs should be opened as a separate tab to the file directly, since modern browsers have the ability to view pdfs.

Example:
How Access The Data's pdf file currently opens
How it should open

Action Items

  • Download a copy of Access The Data's overview pdf and put it in /assets/pdfs
  • Change the 'Overview' link for the markdown file to point to the pdf file living under /assets/pdfs
  • Ensure that the links in both the project page and the project's dedicated page open the pdf file properly after the change

Resources/Instructions

Markdown file
Project Page
Location for pdf files
Jekyll Static Files

@github-actions github-actions bot added Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing size: missing labels Sep 8, 2021
@macho-catt macho-catt added Feature: Refactor HTML role: front end Tasks for front end developers Size: Good second issue and removed Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing size: missing labels Sep 8, 2021
@macho-catt macho-catt changed the title Change the 'Overview' link for Access The Data project to open as a pdf file in the browser instead of opening a google doc Refactor HTML: Update how 'Overview' link opens for Access The Data Sep 8, 2021
@macho-catt macho-catt changed the title Refactor HTML: Update how 'Overview' link opens for Access The Data Update how 'Overview' link opens for Access The Data Sep 8, 2021
@anthonysim anthonysim self-assigned this Dec 3, 2021
@anthonysim
Copy link
Member

anthonysim commented Dec 3, 2021

Availability for this week:
Wed (12/8): 5 - 7 PM
Fri (12/10): 5 - 7 PM
Sat (12/11): 11 - 1 PM
My estimated ETA for completing this issue: 12/11/2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Refactor HTML good first issue Good for newcomers role: front end Tasks for front end developers size: missing Status: Updated No blockers and update is ready for review
Projects
Development

Successfully merging a pull request may close this issue.

4 participants