Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update how 'Overview' link opens for Youth Justice Nav #2243

Closed
3 tasks done
Tracked by #2211
macho-catt opened this issue Sep 8, 2021 · 2 comments · Fixed by #2780
Closed
3 tasks done
Tracked by #2211

Update how 'Overview' link opens for Youth Justice Nav #2243

macho-catt opened this issue Sep 8, 2021 · 2 comments · Fixed by #2780
Assignees
Labels
Feature: Refactor HTML good first issue Good for newcomers role: front end Tasks for front end developers size: missing Status: Updated No blockers and update is ready for review

Comments

@macho-catt
Copy link
Member

macho-catt commented Sep 8, 2021

Overview

As a user, clicking on the 'Overview' link for the Youth Justice Nav project should open a new tab to the pdf file directly. This is made as an action item of #2211

Details

When clicking the 'Overview' link, each project page acts differently. Some open to a google docs page, others open to a github page that hosts the pdf file, and another downloads the pdf file locally to the machine. There needs to be a standard in how the pdf files open. Developers decided during the backend meeting that pdfs should be opened as a separate tab to the file directly, since modern browsers have the ability to view pdfs.

Example:
How Youth Justice Nav's pdf file currently opens
How it should open

Action Items

  • Download a copy of Youth Justice Nav's overview pdf and put it in /assets/pdfs
  • Change the 'Overview' link for the markdown file to point to the pdf file living under /assets/pdfs
  • Ensure that the links in both the project page and the project's dedicated page open the pdf file properly after the change

Resources/Instructions

Markdown file
Project Page
Location for pdf files
Jekyll Static Files

@github-actions github-actions bot added Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing size: missing labels Sep 8, 2021
@macho-catt macho-catt changed the title Change the 'Overview' link for Youth Justice Nav project to open as a pdf file in the browser instead of opening a github page that hosts the pdf file Update how 'Overview' link opens for Youth Justice Nav Sep 8, 2021
@macho-catt macho-catt added Feature: Refactor HTML role: front end Tasks for front end developers Size: Good second issue Ready for Prioritization and removed Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing size: missing labels Sep 8, 2021
@luke-karis luke-karis self-assigned this Feb 10, 2022
@luke-karis
Copy link
Member

Availability for this week: Thursday after 8pm, Friday after 4pm
My estimated ETA for completing this issue: not sure, I'm a little blocked right now but I'm going to look at this with fresh eyes on Thursday and if I'm still stuck I'll reach out to the channel.

@github-actions github-actions bot added the Status: Updated No blockers and update is ready for review label Feb 11, 2022
@luke-karis
Copy link
Member

I have a blocker. I believe that I have made all the changes suggested in this ticket: downloading and copying the pdf into assets/pdfs and changing the overview link in the markdown file.

These changes can be found on this branch in my forked website repo Update-youth-justive-nav-overview-link-2243

The overview link on Youth Justice Nav's dedicated page works fine but the one in the project page still takes you to the GitHub pdf. I'm not sure why this isn't working especially after looking at some other similar issues and PRs that seemed to have worked with just the change I have implemented.

Any help with this would be appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Refactor HTML good first issue Good for newcomers role: front end Tasks for front end developers size: missing Status: Updated No blockers and update is ready for review
Projects
Development

Successfully merging a pull request may close this issue.

4 participants