[DS-379] Add a warning for misuse of Popover (#166)

gsoft-inc · Oct 21, 2024 · d576821 · d576821
1 parent 5b96aca
commit d576821
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/.changeset/witty-cheetahs-walk.md b/.changeset/witty-cheetahs-walk.md
@@ -0,0 +1,5 @@
+---
+"@workleap/orbiter-ui": patch
+---
+
+Add a warning when user doesn't add a Heading or an aria-label attribute to a Popover
diff --git a/packages/components/src/popover/src/Popover.tsx b/packages/components/src/popover/src/Popover.tsx
@@ -118,6 +118,10 @@ export function InnerPopover({
         }
     }), [popoverId]));
 
+    if (isNil(heading) && isNil(ariaLabel)) {
+        console.error("A popover must either have a heading or an \"aria-label\" attribute.");
+    }
+
     const headingId = heading?.props?.id;
 
     const footerMarkup = isString(footer?.props?.children)