[DS-379] Make heading optional in Popover (#164)

gsoft-inc · Oct 18, 2024 · 5b96aca · 5b96aca
1 parent fd1f5e7
commit 5b96aca
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 1 deletion.
diff --git a/.changeset/angry-panthers-try.md b/.changeset/angry-panthers-try.md
@@ -0,0 +1,5 @@
+---
+"@workleap/orbiter-ui": patch
+---
+
+Heading is now optional in Popover
diff --git a/packages/components/src/popover/src/Popover.tsx b/packages/components/src/popover/src/Popover.tsx
@@ -92,7 +92,7 @@ export function InnerPopover({
 
     const { button, "button-group": buttonGroup, content, footer, heading } = useSlots(children, useMemo(() => ({
         _: {
-            required: ["heading", "content"]
+            required: ["content"]
         },
         button: {
             className: "o-ui-popover-button",

diff --git a/packages/components/src/popover/tests/chromatic/Popover.stories.tsx b/packages/components/src/popover/tests/chromatic/Popover.stories.tsx
@@ -207,3 +207,12 @@ export const Style: PopoverStory = {
         </Popover>
     )
 };
+
+export const NoHeading: PopoverStory = {
+    storyName: "no heading",
+    render: () => (
+        <Popover>
+            <Content>SpaceX designs, manufactures, and launches the world's most advanced rockets and spacecraft.</Content>
+        </Popover>
+    )
+};