Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add new name for redirects #102

Merged
merged 1 commit into from
Dec 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

Event Scheduling for Groups

[Access it here](https://appfor.it)
[Access it here](https://grup.rsvp)

## Getting started

Expand Down
17 changes: 17 additions & 0 deletions android/app/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
</intent-filter>

<meta-data android:name="flutter_deeplinking_enabled" android:value="true"/>
<!-- Deprecated -->
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<!-- Deprecated -->
<!-- Depreciated -->

<intent-filter android:autoVerify="true">
<action android:name="android.intent.action.VIEW"/>
<category android:name="android.intent.category.DEFAULT"/>
Expand All @@ -36,12 +37,28 @@
<data android:scheme="https"/>
</intent-filter>

<intent-filter android:autoVerify="true">
<action android:name="android.intent.action.VIEW"/>
<category android:name="android.intent.category.DEFAULT"/>
<category android:name="android.intent.category.BROWSABLE"/>
<data android:scheme="http" android:host="grup.rsvp"/>
<data android:scheme="https"/>
</intent-filter>

<!-- Deprecated -->
<intent-filter>
<action android:name="android.intent.action.VIEW"/>
<category android:name="android.intent.category.DEFAULT"/>
<category android:name="android.intent.category.BROWSABLE"/>
<data android:scheme="appforit"/>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We keep it because of the current confirmation emails? Once we change those, I guess we can remove it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, one could say this is a step in between

</intent-filter>

<intent-filter>
<action android:name="android.intent.action.VIEW"/>
<category android:name="android.intent.category.DEFAULT"/>
<category android:name="android.intent.category.BROWSABLE"/>
<data android:scheme="grup"/>
</intent-filter>
</activity>
<!-- Don't delete the meta-data below.
This is used by the Flutter tool to generate GeneratedPluginRegistrant.java -->
Expand Down
1 change: 1 addition & 0 deletions ios/Runner/Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@
<array>
<string>com.googleusercontent.apps.655087059227-o10vdnfsvnkl9ct8isg8db3j74s0rfur</string>
<string>appforit</string>
<string>grup</string>
</array>
</dict>
</array>
Expand Down
2 changes: 2 additions & 0 deletions ios/Runner/Runner.entitlements
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
<array>
<string>applinks:appfor.it</string>
<string>webcredentials:appfor.it</string>
<string>applinks:grup.rsvp</string>
<string>webcredentials:grup.rsvp</string>
</array>
</dict>
</plist>
2 changes: 1 addition & 1 deletion lib/l10n/app_en.arb
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@
},
"link": {
"type": "String",
"example": "https://appfor.it/invite/ABCD-EFGH"
"example": "https://grup.rsvp/invite/ABCD-EFGH"
}
}
},
Expand Down
2 changes: 1 addition & 1 deletion lib/presentation/screens/auth.dart
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ class AuthScreen extends StatelessWidget {
/// This is needed to handle different ports
/// when launching on localhost.
String? _getRedirectUrl() {
if (!kIsWeb) return 'appforit://auth-callback';
if (!kIsWeb) return 'grup://auth-callback';

final currentUrl = html.window.location.href;
final uri = Uri.parse(currentUrl);
Expand Down
2 changes: 1 addition & 1 deletion lib/presentation/screens/group_member_details.dart
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ class GroupMemberDetailsScreen extends StatelessWidget {

final l10n = AppLocalizations.of(context)!;
final code = invite.value;
final deeplink = Uri.https('appfor.it', '/join/$code').toString();
final deeplink = Uri.https('grup.rsvp', '/join/$code').toString();

return Share.share(l10n.inviteMessage(code, deeplink));
}
Expand Down
4 changes: 2 additions & 2 deletions supabase/config.toml
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,9 @@ file_size_limit = "50MiB"
[auth]
# The base URL of your website. Used as an allow-list for redirects and for constructing URLs used
# in emails.
site_url = "https://appfor.it"
site_url = "https://grup.rsvp"
# A list of *exact* URLs that auth providers are permitted to redirect to post authentication.
additional_redirect_urls = ["http://localhost:*", "appforit://auth-callback"]
additional_redirect_urls = ["http://localhost:*", "grup://auth-callback"]
# How long tokens are valid for, in seconds. Defaults to 3600 (1 hour), maximum 604,800 seconds (one
# week).
jwt_expiry = 3600
Expand Down
Loading