Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add new name for redirects #102

Merged
merged 1 commit into from
Dec 8, 2024
Merged

refactor: add new name for redirects #102

merged 1 commit into from
Dec 8, 2024

Conversation

borgoat
Copy link
Member

@borgoat borgoat commented Dec 8, 2024

No description provided.

@borgoat
Copy link
Member Author

borgoat commented Dec 8, 2024

Manual config still pending

@@ -28,6 +28,7 @@
</intent-filter>

<meta-data android:name="flutter_deeplinking_enabled" android:value="true"/>
<!-- Deprecated -->
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<!-- Deprecated -->
<!-- Depreciated -->

<data android:scheme="https"/>
</intent-filter>

<!-- Deprecated -->
<intent-filter>
<action android:name="android.intent.action.VIEW"/>
<category android:name="android.intent.category.DEFAULT"/>
<category android:name="android.intent.category.BROWSABLE"/>
<data android:scheme="appforit"/>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We keep it because of the current confirmation emails? Once we change those, I guess we can remove it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, one could say this is a step in between

@inpt333 inpt333 merged commit 8aca26f into main Dec 8, 2024
1 check passed
@inpt333 inpt333 deleted the refactor/domain-name branch December 8, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants