feat(Card): use common constants for card's radiuses #1682
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arucard89
added
enhancement
|
Preview is ready. |
|
Visual Tests Report is ready. |
Arucard89
requested review from
Lunory,
amje,
ValeraS and
korvin89
as code owners
korvin89
reviewed
Jun 28, 2024
src/components/Card/Card.scss
Outdated
| @@ -157,11 +157,11 @@ $block: '.#{variables.$ns}card'; | |||
|
|
|||
| &_size { | |||
| &_m { | |||
| --_--border-radius: 8px; | |||
| --_--border-radius: var(--g-border-radius-l); | |||
There was a problem hiding this comment.
Why we use --g-border-radius-l for size_m?
There was a problem hiding this comment.
Card's border sizes don't have straight accordance to radius constants. I have choosen constants by values.
https://github.com/gravity-ui/uikit/blob/main/styles/themes/common/_index.scss#L13
There was a problem hiding this comment.
@amje I think it is a not good idea to use symantic variables in such cases
There was a problem hiding this comment.
What do you think about adding variables for cards to _index.scss?
For example:
—g-border-radius-card-m
—g-border-radius-card-l
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
source:
feat: add border radius tab landing#220 (comment)